[Rust] Segfault while array buffer append #26643
Description
// src/buffer.rs:657
/// Ensures that this buffer has at least
capacityslots in this buffer. This will
/// also ensure the new capacity will be a multiple of 64 bytes.
///
/// Returns the new capacity for this buffer.
pub fn reserve(&mut self, capacity: usize) -> Result {
if capacity > self.capacity {
unsafe { memory :: reallocate(self.data, self.capacity, new_capacity) };
self.data = new_data as *mut u8;
self.capacity = new_capacity;
}
Ok(self.capacity)
}
Above code is not checking if new_data is null, which is causing segfault on following memcpy when reallocate failed.
Environment: Ubuntu 20.04. rustc-nightly,
Reporter: Ziru Niu
Assignee: Jorge Leitão / @jorgecarleitao
Related issues:
- Segfault in (Blocked)
- [Rust] Add bench to MutableBuffer (relates to)
PRs and other links:
Note: This issue was originally created as ARROW-10692. Please see the migration documentation for further details.