Skip to content

[Rust] Use slices for simple array data buffer access #27171

@asfimport

Description

@asfimport

Using an approach similar to ARROW-10989, migrate typed array API's to use slices where they can.

This impacts the API of:

  • GenericBinaryArray<>

  • GenericListArray<>

  • GenericStringArray<>

    This also enables bounds checking in every value() function on each of the above arrays (as well as PrimitiveArray<> ).

    The new PrimitiveArray.value() bounds check  has a negative performance impact on various benchmarks that still use the .Value(...) function on PrimitiveArray.  But that should be resolvable by using the PrimitiveArray.values() instead (whether within this PR or a future PR).

Reporter: Tyrel Rink / @tyrelr
Assignee: Tyrel Rink / @tyrelr

PRs and other links:

Note: This issue was originally created as ARROW-11270. Please see the migration documentation for further details.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions