-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Description
Rust clippy lint test on CI started failing with this error:
Compiling arrow-flight v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/arrow-flight)
error: use of deprecated struct `criterion::Benchmark`: Please use BenchmarkGroups instead.
--> arrow/benches/builder.rs:39:9
|
39 | Benchmark::new("bench_primitive", move |b| {
| ^^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: use of deprecated struct `criterion::Benchmark`: Please use BenchmarkGroups instead.
--> arrow/benches/builder.rs:62:9
|
62 | Benchmark::new("bench_bool", move |b| {
| ^^^^^^^^^^^^^^
error: use of deprecated associated function `criterion::Criterion::<M>::bench`: Please use BenchmarkGroups instead.
--> arrow/benches/builder.rs:37:7
|
37 | c.bench(
| ^^^^^
error: use of deprecated associated function `criterion::Criterion::<M>::bench`: Please use BenchmarkGroups instead.
--> arrow/benches/builder.rs:60:7
|
60 | c.bench(
| ^^^^^It appears related to the latest release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)
Reporter: Andrew Lamb / @alamb
Assignee: Jorge Leitão / @jorgecarleitao
PRs and other links:
Note: This issue was originally created as ARROW-11375. Please see the migration documentation for further details.