Skip to content

[R][Packaging] Fix pkg-config check in r/configure #28355

@asfimport

Description

@asfimport

I installed the arrow R package version 4.0.0 from CRAN on an Intel Mac that does not have pkg-config installed, and I saw this in the installation log

./configure: line 81: pkg-config: command not found
./configure: line 82: pkg-config: command not found
./configure: line 83: pkg-config: command not found 

This is happening because of line 79 and 80:

pkg-config --version >/dev/null 2>&1
if [ "$ARROW_USE_PKG_CONFIG" != "false" ] && [ $? -eq 0 ]; then 

The first conditional on line 80 causes $? to be set to 0, so then the second conditional evaluates to true. Reverse the order of these two conditionals so that $? truly reflects whether pkg-config is installed.

Reporter: Ian Cook / @ianmcook
Assignee: Ian Cook / @ianmcook

PRs and other links:

Note: This issue was originally created as ARROW-12601. Please see the migration documentation for further details.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions