[C++] Suppress vcpkg manifest disabled messages from msbuild

[asfimport]

When building the Arrow library without using vcpkg on a Windows system that has vcpkg installed, msbuild emits this message repeatedly during the build:

The vcpkg manifest was disabled, but we found a manifest file in $(VcpkgManifestRoot). You may want to enable vcpkg manifests in your properties page or pass /p:VcpkgEnableManifest=true to the msbuild invocation.
This is of no consequence but it's annoying. See if we can configure the cmake files to add /p:VcpkgEnableManifest=false to the compiler flags to suppress this message when vcpkg is not being used for dependencies.

E.g. in SetupCxxFlags.cmake, add a conditional like this, including a status message.

if(MSVC AND NOT ARROW_DEPENDENCY_SOURCE STREQUAL "VCPKG")
  message(STATUS "Disabling the vcpkg manifest. To enable the vcpkg manifest, set -DARROW_DEPENDENCY_SOURCE=VCPKG")
  set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /p:VcpkgEnableManifest=false")
endif()

 

Reporter: Ian Cook / @ianmcook

Related issues:

• [C++] Add vcpkg.json manifest to cpp project root (relates to)

_{Note: This issue was originally created as ARROW-12886. Please see the migration documentation for further details.}

[asfimport]

Todd Farmer / @toddfarmer:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.