[JS] Archery JS Build Fails

[asfimport]

We are seeing CI failures running the JS integration tests - https://github.com/apache/arrow-rs/runs/7824734614?check_suite_focus=true

In particular

 

    [07:33:01] Error: gulp-google-closure-compiler: java.util.zip.ZipException: invalid entry CRC (expected 0x4e1f14a4 but got 0xb1e0eb5b)
    	at java.util.zip.ZipInputStream.readEnd(ZipInputStream.java:410)
    	at java.util.zip.ZipInputStream.read(ZipInputStream.java:199)
    	at java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:143)
    	at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:121)
    	at com.google.javascript.jscomp.AbstractCommandLineRunner.getBuiltinExterns(AbstractCommandLineRunner.java:500)
    	at com.google.javascript.jscomp.CommandLineRunner.createExterns(CommandLineRunner.java:2084)
    	at com.google.javascript.jscomp.AbstractCommandLineRunner.doRun(AbstractCommandLineRunner.java:1187)
    	at com.google.javascript.jscomp.AbstractCommandLineRunner.run(AbstractCommandLineRunner.java:551)
    	at com.google.javascript.jscomp.CommandLineRunner.main(CommandLineRunner.java:2246)
    Error writing to stdin of the compiler. write EPIPE 

 

This appears to be an issue with zlib v1.2.12 madler/zlib#613 according to the corresponding issue on google-closure-compiler - google/closure-compiler-npm#234

I'm not sure what the solution here is, but thought I would flag it

 

Reporter: Raphael Taylor-Davies / @tustvold
Assignee: Matthew Topol / @zeroshade

Related issues:

• [JS] Integration test build fails with 'gulp-google-closure-compiler: java.util.zip.ZipException: invalid entry CRC' (is duplicated by)
• [CI] conda-integration builds failing due to pinned zlib (is related to)

PRs and other links:

• GitHub Pull Request #13885

_{Note: This issue was originally created as ARROW-17410. Please see the migration documentation for further details.}

[asfimport]

Matthew Topol / @zeroshade:
It looks like the solution, for now, would be to downgrade to v1.2.11 until the fix mentioned in that issue gets released.

[asfimport]

Matthew Topol / @zeroshade:
So this is interesting, I can't replicate this failure with just running the JS build. I think it only fails in the integration test build, which is odd. I'll dig a bit more.

[asfimport]

Raphael Taylor-Davies / @tustvold:
Thank you for looking into this, perhaps the conda environment is providing a newer zlib than the system verison, which the JS build only finds when run within the integration context?

[asfimport]

Matthew Topol / @zeroshade:
@tustvold so this gets more interesting, when I run archery docker run conda-integration locally, I don't get this JS build failure.....

[asfimport]

Raphael Taylor-Davies / @tustvold:
I did some work to simplify the CI so that it can perhaps be more easily reproduced - https://github.com/apache/arrow-rs/pull/2453/files

 

Fortunately it appears to be deterministic, but I'm not exactly sure what is causing it...

[asfimport]

Matthew Topol / @zeroshade:
Looks like it specifically requires npx and other native platform compilers to exist / be installed (I hate JavaScript with a passion) anyway, I've confirmed that downgrading to zlib==1.2.11 fixes the issue and put up a PR for it

[asfimport]

Matthew Topol / @zeroshade:
Issue resolved by pull request 13885
#13885