ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible#10093
Closed
kszucs wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible#10093kszucs wants to merge 2 commits intoapache:masterfrom
kszucs wants to merge 2 commits intoapache:masterfrom
Conversation
kszucs
commented
Apr 18, 2021
Member
Author
|
I reproduced the problem using a simple cast test from null array to a dictionary array: TEST(Cast, FromNullToDictionary) {
auto from = std::make_shared<NullArray>(10);
auto to_type = dictionary(int8(), boolean());
ASSERT_OK_AND_ASSIGN(auto expected, MakeArrayOfNull(to_type, 10));
CheckCast(from, expected);
}Somewhere cc @bkietz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.