ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

[zhztheplayer]

https://issues.apache.org/jira/browse/ARROW-11776

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[emkornfield]

seems like this loop and the loop below could be combinded.

[zhztheplayer]

fixed in c16e0cb, PR #10201

[emkornfield]

mixing style changes like this with new code makes reviews harder, please try to avoid large scale changes like this in the future.

[zhztheplayer]

Thanks for the suggestion.

[emkornfield]

why are we using protos for this information?

[emkornfield]

In particular this for the most part looks like it replicates data already defined in flatbuffers.

[zhztheplayer]

Migrated to flatbuffers in PR #10201

[emkornfield]

combine this line with the previous? close can take multiple parameters i believe.

[zhztheplayer]

They are not able to be combined directly. The first line calls code

arrow/java/memory/memory-core/src/main/java/org/apache/arrow/util/AutoCloseables.java

Lines 82 to 109 in 0a3cbd0

	public static void close(Iterable<? extends AutoCloseable> ac) throws Exception {
	// this method can be called on a single object if it implements Iterable<AutoCloseable>
	// like for example VectorContainer make sure we handle that properly
	if (ac == null) {
	return;
	} else if (ac instanceof AutoCloseable) {
	((AutoCloseable) ac).close();
	return;
	}
	Exception topLevelException = null;
	for (AutoCloseable closeable : ac) {
	try {
	if (closeable != null) {
	closeable.close();
	}
	} catch (Exception e) {
	if (topLevelException == null) {
	topLevelException = e;
	} else if (e != topLevelException) {
	topLevelException.addSuppressed(e);
	}
	}
	}
	if (topLevelException != null) {
	throw topLevelException;
	}
	}

second line calls

arrow/java/memory/memory-core/src/main/java/org/apache/arrow/util/AutoCloseables.java

Lines 74 to 76 in 0a3cbd0

	public static void close(AutoCloseable... autoCloseables) throws Exception {
	close(Arrays.asList(autoCloseables));
	}

[zhztheplayer]

Hi @emkornfield (and anyone who has been reviewing), sorry I made a mistake of deleting the original branch and the PR is now not able to reopen. Now I can only open a new PR: #10201. Sorry again for that.