Skip to content

ARROW-12515 [Dev][Wiki][Release]: Fix and update Windows RC verify script [WIP] #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianmcook wants to merge 5 commits into from
Closed

ARROW-12515 [Dev][Wiki][Release]: Fix and update Windows RC verify script [WIP] #10136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
966f9fe
Fix bad relative paths to conda yml files
ianmcook Apr 22, 2021
b78efca
Use curl instead of wget
ianmcook Apr 22, 2021
1a9c815
Use python 3.8
ianmcook Apr 22, 2021
084b403
Use VS 2019
ianmcook Apr 22, 2021
08e9aab
Update VS version in dev readme
ianmcook Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Currently this only works on Linux (patches to expand to macOS welcome!). Read
the script for information about system dependencies.

On Windows, we have a script that verifies C++ and Python (requires Visual
Studio 2015):
Studio 2019):

```
dev/release/verify-release-candidate.bat apache-arrow-0.7.0.tar.gz
Expand Down
17 changes: 8 additions & 9 deletions dev/release/verify-release-candidate.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,25 +32,24 @@ set _TARBALL=apache-arrow-%1.tar.gz
set ARROW_SOURCE=%_VERIFICATION_DIR%\apache-arrow-%1
set INSTALL_DIR=%_VERIFICATION_DIR%\install

@rem Requires GNU Wget for Windows
wget --no-check-certificate -O %_TARBALL% %_DIST_URL%/apache-arrow-%1-rc%2/%_TARBALL% || exit /B 1
curl -k -O %_DIST_URL%/apache-arrow-%1-rc%2/%_TARBALL% || exit /B 1

tar xf %_TARBALL% -C %_VERIFICATION_DIR_UNIX%

set PYTHON=3.6
set PYTHON=3.8

@rem Using call with conda.bat seems necessary to avoid terminating the batch
@rem script execution
call conda create --no-shortcuts -c conda-forge -f -q -y -p %_VERIFICATION_CONDA_ENV% ^
--file=ci\conda_env_cpp.yml ^
--file=ci\conda_env_python.yml ^
--file=%ARROW_SOURCE%\ci\conda_env_cpp.yml ^
--file=%ARROW_SOURCE%\ci\conda_env_python.yml ^
git ^
python=%PYTHON% ^
|| exit /B 1

call activate %_VERIFICATION_CONDA_ENV% || exit /B 1

set GENERATOR=Visual Studio 15 2017 Win64
set GENERATOR=Visual Studio 16 2019
set CONFIGURATION=release

pushd %ARROW_SOURCE%
Expand All @@ -63,13 +62,13 @@ set PATH=%INSTALL_DIR%\bin;%PATH%
mkdir %ARROW_SOURCE%\cpp\build
pushd %ARROW_SOURCE%\cpp\build

@rem This is the path for Visual Studio Community 2017
call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\VsDevCmd.bat" -arch=amd64
@rem This is the path for Visual Studio Community 2019
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools\VsDevCmd.bat" -arch=amd64

@rem NOTE(wesm): not using Ninja for now to be able to more easily control the
@rem generator used

cmake -G "%GENERATOR%" ^
cmake -G "%GENERATOR%" -A x64 ^
-DARROW_BOOST_USE_SHARED=ON ^
-DARROW_BUILD_STATIC=OFF ^
-DARROW_BUILD_TESTS=ON ^
Expand Down