ARROW-12568: [C++][Compute] Fix nullptr deference when array contains no nulls #10184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Appveyor CI failure looks a spurious network issue: |
Contributor
Author
|
Turns out there are more "buffers[0]->data()" codes where "buffers[0]" is not checked for null.
Shall we include all fixes in this single PR? @kszucs @pitrou EDIT: fixes included in this pr. |
Member
|
@cyb70289 That would be nice, yes! |
cyb70289
commented
Apr 28, 2021
cyb70289
changed the title
pitrou
reviewed
Apr 29, 2021
pitrou
reviewed
May 3, 2021
| @@ -175,15 +175,24 @@ struct KleeneAnd : Commutative<KleeneAnd> { | |||
| } | |||
|
|
|||
| if (right_true) { | |||
| GetBitmap(*out, 0).CopyFrom(GetBitmap(left, 0)); | |||
| if (left.GetNullCount() == 0) { | |||
| GetBitmap(*out, 0).SetBitsTo(true); | |||
Member
There was a problem hiding this comment.
How about instead:
out->null_count = 0;
out->buffers[0] = nullptr;
Contributor
Author
There was a problem hiding this comment.
Done.
Looks it's better to tell the scalar kernel framework not to pre-allocate the valid buffer.
pitrou
approved these changes
May 3, 2021
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
May 17, 2021
… no nulls Closes apache#10184 from cyb70289/12568-cast-crash Lead-authored-by: Yibo Cai <yibo.cai@arm.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.