Skip to content

ARROW-12199: [R] bindings for stddev, variance #10215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thisisnic wants to merge 10 commits into from
Closed

ARROW-12199: [R] bindings for stddev, variance #10215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0510ea0
Add sd and var dplyr bindings
thisisnic Apr 30, 2021
57fe43e
Add bindings and tests for stddev and variance
thisisnic Apr 30, 2021
5a3ad9a
Remove bindings for stddev and variance
thisisnic Apr 30, 2021
0b704ae
Make sd fail if in dplyr call
thisisnic Apr 30, 2021
a5ebe89
Remove tests for removed bindings
thisisnic Apr 30, 2021
6604ef0
Remove import of var and sd
thisisnic Apr 30, 2021
0c90152
Fix linting
thisisnic Apr 30, 2021
df4bc4d
Add in tests for variance and stddev
thisisnic May 4, 2021
50ffbe3
Whitespace fix
thisisnic May 4, 2021
ae46e55
Change values in case weird floating point stuff happening
thisisnic May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions r/R/dplyr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ arrow_mask <- function(.data) {
# Some R functions will still try to evaluate on an Expression
# and return NA with a warning
fail <- function(...) stop("Not implemented")
for (f in c("mean")) {
for (f in c("mean", "sd")) {
f_env[[f]] <- fail
}

Expand Down Expand Up @@ -1006,7 +1006,6 @@ abandon_ship <- function(call, .data, msg = NULL) {
stop(msg, "\nCall collect() first to pull data into R.", call. = FALSE)
}
}

# else, collect and call dplyr method
if (!is.null(msg)) {
warning(msg, "; pulling data into R", immediate. = TRUE, call. = FALSE)
Expand Down
5 changes: 5 additions & 0 deletions r/src/compute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,11 @@ std::shared_ptr<arrow::compute::FunctionOptions> make_compute_options(
max_replacements);
}

if (func_name == "variance" || func_name == "stddev") {
Copy link
Member

@nealrichardson nealrichardson Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH this is probably the only code addition we want to keep here.

using Options = arrow::compute::VarianceOptions;
return std::make_shared<Options>(cpp11::as_cpp<int64_t>(options["ddof"]));
}

return nullptr;
}

Expand Down
18 changes: 18 additions & 0 deletions r/tests/testthat/test-compute-aggregate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,3 +381,21 @@ test_that("all.Array and all.ChunkedArray", {
expect_vector_equal(all(input, na.rm = TRUE), data_logical)

})

test_that("variance", {
data <- c(-37, 267, 88, -120, 9, 101, -65, -23, NA)
arr <- Array$create(data)
chunked_arr <- ChunkedArray$create(data)

expect_equal(call_function("variance", arr, options = list(ddof = 5)), Scalar$create(34596))
expect_equal(call_function("variance", chunked_arr, options = list(ddof = 5)), Scalar$create(34596))
})

test_that("stddev", {
data <- c(-37, 267, 88, -120, 9, 101, -65, -23, NA)
arr <- Array$create(data)
chunked_arr <- ChunkedArray$create(data)

expect_equal(call_function("stddev", arr, options = list(ddof = 5)), Scalar$create(186))
expect_equal(call_function("stddev", chunked_arr, options = list(ddof = 5)), Scalar$create(186))
})