Skip to content

ARROW-12725: [C++][Compute] Column at a time hash and comparison in group by #10290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michalursa wants to merge 6 commits into from
Closed

ARROW-12725: [C++][Compute] Column at a time hash and comparison in group by #10290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8227842
Column-at-a-time comparison and hashing for Group Identifier
michalursa Aug 4, 2021
5e1272d
Column-at-a-time comparison and hashing - refactoring of binary compa…
michalursa Aug 13, 2021
5981c5f
support dict columns in SortBy
bkietz Aug 18, 2021
4025a82
Column-at-a-time comparison and hashing for Group Identifier
michalursa Aug 4, 2021
aee5b11
Column-at-a-time comparison and hashing - refactoring of binary compa…
michalursa Aug 13, 2021
5294f98
Column-at-a-time comparison and hashing - fixing merge problems
michalursa Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
548 changes: 352 additions & 196 deletions cpp/src/arrow/compute/exec/key_compare.cc
View file
Open in desktop

Large diffs are not rendered by default.

138 changes: 87 additions & 51 deletions cpp/src/arrow/compute/exec/key_compare.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,66 +33,102 @@ class KeyCompare {
// Returns a single 16-bit selection vector of rows that failed comparison.
// If there is input selection on the left, the resulting selection is a filtered image
// of input selection.
static void CompareRows(uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, uint32_t* out_num_rows,
uint16_t* out_sel_left_maybe_same,
const KeyEncoder::KeyRowArray& rows_left,
const KeyEncoder::KeyRowArray& rows_right);

private:
static void CompareFixedLength(uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map,
uint8_t* match_bytevector,
KeyEncoder::KeyEncoderContext* ctx,
uint32_t fixed_length, const uint8_t* rows_left,
const uint8_t* rows_right);
static void CompareVaryingLength(uint32_t num_rows_to_compare,
static void CompareColumnsToRows(uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map,
uint8_t* match_bytevector,
KeyEncoder::KeyEncoderContext* ctx,
const uint8_t* rows_left, const uint8_t* rows_right,
const uint32_t* offsets_left,
const uint32_t* offsets_right);

// Second template argument is 0, 1 or 2.
// 0 means arbitrarily many 64-bit words, 1 means up to 1 and 2 means up to 2.
template <bool use_selection, int num_64bit_words>
static void CompareFixedLengthImp(uint32_t num_rows_already_processed,
uint32_t num_rows,
uint32_t* out_num_rows,
uint16_t* out_sel_left_maybe_same,
const std::vector<KeyEncoder::KeyColumnArray>& cols,
const KeyEncoder::KeyRowArray& rows);

private:
template <bool use_selection>
static void NullUpdateColumnToRow(uint32_t id_col, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map,
uint8_t* match_bytevector, uint32_t length,
const uint8_t* rows_left, const uint8_t* rows_right);
KeyEncoder::KeyEncoderContext* ctx,
const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows,
uint8_t* match_bytevector);

template <bool use_selection, class COMPARE_FN>
static void CompareBinaryColumnToRowHelper(
uint32_t offset_within_row, uint32_t first_row_to_compare,
uint32_t num_rows_to_compare, const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map, KeyEncoder::KeyEncoderContext* ctx,
const KeyEncoder::KeyColumnArray& col, const KeyEncoder::KeyRowArray& rows,
uint8_t* match_bytevector, COMPARE_FN compare_fn);

template <bool use_selection>
static void CompareVaryingLengthImp(uint32_t num_rows,
const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map,
uint8_t* match_bytevector, const uint8_t* rows_left,
const uint8_t* rows_right,
const uint32_t* offsets_left,
const uint32_t* offsets_right);
static void CompareBinaryColumnToRow(
uint32_t offset_within_row, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

template <bool use_selection, bool is_first_varbinary_col>
static void CompareVarBinaryColumnToRow(
uint32_t id_varlen_col, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

static void AndByteVectors(KeyEncoder::KeyEncoderContext* ctx, uint32_t num_elements,
uint8_t* bytevector_A, const uint8_t* bytevector_B);

#if defined(ARROW_HAVE_AVX2)

static uint32_t CompareFixedLength_UpTo8B_avx2(
uint32_t num_rows, const uint32_t* left_to_right_map, uint8_t* match_bytevector,
uint32_t length, const uint8_t* rows_left, const uint8_t* rows_right);
static uint32_t CompareFixedLength_UpTo16B_avx2(
uint32_t num_rows, const uint32_t* left_to_right_map, uint8_t* match_bytevector,
uint32_t length, const uint8_t* rows_left, const uint8_t* rows_right);
static uint32_t CompareFixedLength_avx2(uint32_t num_rows,
const uint32_t* left_to_right_map,
uint8_t* match_bytevector, uint32_t length,
const uint8_t* rows_left,
const uint8_t* rows_right);
static void CompareVaryingLength_avx2(
uint32_t num_rows, const uint32_t* left_to_right_map, uint8_t* match_bytevector,
const uint8_t* rows_left, const uint8_t* rows_right, const uint32_t* offsets_left,
const uint32_t* offsets_right);
template <bool use_selection>
static uint32_t NullUpdateColumnToRowImp_avx2(
uint32_t id_col, uint32_t num_rows_to_compare, const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map, KeyEncoder::KeyEncoderContext* ctx,
const KeyEncoder::KeyColumnArray& col, const KeyEncoder::KeyRowArray& rows,
uint8_t* match_bytevector);

template <bool use_selection, class COMPARE8_FN>
static uint32_t CompareBinaryColumnToRowHelper_avx2(
uint32_t offset_within_row, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector,
COMPARE8_FN compare8_fn);

template <bool use_selection>
static uint32_t CompareBinaryColumnToRowImp_avx2(
uint32_t offset_within_row, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

template <bool use_selection, bool is_first_varbinary_col>
static void CompareVarBinaryColumnToRowImp_avx2(
uint32_t id_varlen_col, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

static uint32_t AndByteVectors_avx2(uint32_t num_elements, uint8_t* bytevector_A,
const uint8_t* bytevector_B);

static uint32_t NullUpdateColumnToRow_avx2(
bool use_selection, uint32_t id_col, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

static uint32_t CompareBinaryColumnToRow_avx2(
bool use_selection, uint32_t offset_within_row, uint32_t num_rows_to_compare,
const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
KeyEncoder::KeyEncoderContext* ctx, const KeyEncoder::KeyColumnArray& col,
const KeyEncoder::KeyRowArray& rows, uint8_t* match_bytevector);

static void CompareVarBinaryColumnToRow_avx2(
bool use_selection, bool is_first_varbinary_col, uint32_t id_varlen_col,
uint32_t num_rows_to_compare, const uint16_t* sel_left_maybe_null,
const uint32_t* left_to_right_map, KeyEncoder::KeyEncoderContext* ctx,
const KeyEncoder::KeyColumnArray& col, const KeyEncoder::KeyRowArray& rows,
uint8_t* match_bytevector);

#endif
};
Expand Down
Loading