Skip to content

ARROW-12781: [R] Implement is.type() functions for dplyr #10327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianmcook wants to merge 22 commits into from
Closed

ARROW-12781: [R] Implement is.type() functions for dplyr #10327

ianmcook wants to merge 22 commits into from

Conversation

@ianmcook
Copy link
Member

@ianmcook ianmcook commented May 14, 2021 •
edited
Loading

  • implements base R-flavored is.*() functions and rlang is_*() functions for checking column types in dplyr
  • implements a general is() function like methods::is() for the same
  • adds a $type_id() method to Expression and to some other R6 classes that were missing it
  • changes how Expression$type()works, allowing the schema to be assigned to Expression$schema before
  • adds support for the where() select helper in relocate() (but not in other verbs; that's ARROW-12778)

@ianmcook ianmcook requested a review from nealrichardson May 14, 2021 20:37
@github-actions
Copy link

github-actions bot commented May 14, 2021

https://issues.apache.org/jira/browse/ARROW-12781

ianmcook
ianmcook commented May 14, 2021
View reviewed changes
nealrichardson
nealrichardson requested changes May 14, 2021
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for picking this up

@ianmcook ianmcook requested a review from nealrichardson May 21, 2021 03:58
ianmcook
ianmcook commented May 21, 2021
View reviewed changes
ianmcook
ianmcook commented May 22, 2021
View reviewed changes
nealrichardson
nealrichardson requested changes May 26, 2021
View reviewed changes
ianmcook and others added 19 commits May 27, 2021 22:35
@ianmcook
Add type_id() R6 methods for ChunkedArray, Scalar
2855efd
@ianmcook
Store schema in Expression R6 obj and use bind() to bind to a schema
87b8e72
@ianmcook
Add type_id() R6 method for Expression
86d0ab7
@ianmcook
Add is.<type>() functions
7f80a21
@ianmcook
Add is.<type>() tests
967485a
@ianmcook
Add support for tidyselect where() helper in relocate()
d2db003
@ianmcook
Update tests
b68ef06
@ianmcook @nealrichardson
Make as.integer() return false for UINT64
b8016fd 
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
@ianmcook
Enumerate all types
55d7dd6
@ianmcook
Tweak Expression$type(), $type_id()
eea39e2
@ianmcook
Fix map() error
fdee3e8
@ianmcook
Lint and fix comment
466543f
@ianmcook
Use == instead of %% where possible
6687249
@ianmcook
Implement more type checking functions
e055388
@ianmcook
Add more tests
4a53165
@ianmcook
Rename is() args for consistency with methods::is()
5d6830c
@ianmcook
Improve is() implementation and tests
bb57bf6
@ianmcook
Improve is() implementation and tests
69685e3
@ianmcook
Break out type alias string canonicalization into function
65c54c6
@ianmcook ianmcook closed this in ed7ae4d May 30, 2021
This was referenced May 30, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson requested changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianmcook @nealrichardson