ARROW-13036: [Doc] Mention recommended file extension(s) for Arrow IPC #10512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jun 15, 2021
docs/source/format/Columnar.rst
Outdated
| streaming format) plus memory offsets and sizes for each of the data | ||
| blocks in the file. This enables random access any record batch in the | ||
| file. See `File.fbs`_ for the precise details of the file footer. | ||
| We define a "file format" supporting random access that is built with |
Member
There was a problem hiding this comment.
Since we are at it, can we replace "built with" with something less weird / less confusing? Perhaps "built upon" or "built on top of" or "is an extension of" (or...)?
Member
Author
There was a problem hiding this comment.
I went with "is an extension of"
pitrou
reviewed
Jun 15, 2021
docs/source/format/Columnar.rst
Outdated
| blocks in the file. This enables random access any record batch in the | ||
| file. See `File.fbs`_ for the precise details of the file footer. | ||
| We define a "file format" supporting random access that is built with | ||
| the stream format. We recommend the ".arrow" extension for files. The |
Member
There was a problem hiding this comment.
"for such files" or "for IPC files"?
Member
Author
There was a problem hiding this comment.
I moved the sentence down to the end and changed it to We recommend the ".arrow" extension for files created with this format.
sjperkins
pushed a commit
to sjperkins/arrow
that referenced
this pull request
Jun 23, 2021
See JIRA Closes apache#10512 from westonpace/feature/ARROW-13036--doc-mention-recommended-file-extension-s-for-ar Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
westonpace
deleted the
feature/ARROW-13036--doc-mention-recommended-file-extension-s-for-ar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA