Skip to content

ARROW-12955: [C++] Add additional type support for if_else kernel #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nirandaperera wants to merge 20 commits into from
Closed

ARROW-12955: [C++] Add additional type support for if_else kernel #10538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
542394c
working AAA
nirandaperera Jun 15, 2021
ebc4712
complete binary AAA impl
nirandaperera Jun 15, 2021
129f408
simplifying logic
nirandaperera Jun 15, 2021
b31f791
adding AAS, ASA, ASS
nirandaperera Jun 16, 2021
01a5af1
adding todos
nirandaperera Jun 16, 2021
c5bc550
working on comments
nirandaperera Jun 16, 2021
c27fbe2
fixing null issue
nirandaperera Jun 30, 2021
fc92a9b
templating null-promotion logic
nirandaperera Jun 30, 2021
4e3d225
string impl with non-empty null data for string
nirandaperera Jul 1, 2021
2048bd8
lint changes
nirandaperera Jul 1, 2021
898f1e1
using builders for binary types (for simplicity)
nirandaperera Jul 2, 2021
6aff695
replacing AppendNull w\ UnsafeAppendNull and removing static from met…
nirandaperera Jul 2, 2021
fc3241c
minor changes and fixing compilation error
nirandaperera Jul 2, 2021
41106ed
remove todo's
nirandaperera Jul 2, 2021
30af279
fixing FSB type error and adding unboxing
nirandaperera Jul 13, 2021
ad17b68
adding FSB type impl
nirandaperera Jul 13, 2021
44d3ece
Merge branch 'master' into ARROW-12955
nirandaperera Jul 15, 2021
fdc3228
adding PR comments
nirandaperera Jul 15, 2021
c9db139
lint fixes
nirandaperera Jul 15, 2021
d303ca9
fixing merging error and PR comments
nirandaperera Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cpp/src/arrow/compute/kernels/codegen_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,26 +1222,26 @@ ArrayKernelExec GenerateSignedInteger(detail::GetTypeId get_id) {
// bits).
//
// See "Numeric" above for description of the generator functor
template <template <typename...> class Generator>
template <template <typename...> class Generator, typename... Args>
ArrayKernelExec GenerateTypeAgnosticPrimitive(detail::GetTypeId get_id) {
switch (get_id.id) {
case Type::NA:
return Generator<NullType>::Exec;
return Generator<NullType, Args...>::Exec;
case Type::BOOL:
return Generator<BooleanType>::Exec;
return Generator<BooleanType, Args...>::Exec;
case Type::UINT8:
case Type::INT8:
return Generator<UInt8Type>::Exec;
return Generator<UInt8Type, Args...>::Exec;
case Type::UINT16:
case Type::INT16:
return Generator<UInt16Type>::Exec;
return Generator<UInt16Type, Args...>::Exec;
case Type::UINT32:
case Type::INT32:
case Type::FLOAT:
case Type::DATE32:
case Type::TIME32:
case Type::INTERVAL_MONTHS:
return Generator<UInt32Type>::Exec;
return Generator<UInt32Type, Args...>::Exec;
case Type::UINT64:
case Type::INT64:
case Type::DOUBLE:
Expand All @@ -1250,7 +1250,7 @@ ArrayKernelExec GenerateTypeAgnosticPrimitive(detail::GetTypeId get_id) {
case Type::TIME64:
case Type::DURATION:
case Type::INTERVAL_DAY_TIME:
return Generator<UInt64Type>::Exec;
return Generator<UInt64Type, Args...>::Exec;
default:
DCHECK(false);
return ExecFail;
Expand Down
Loading