ARROW-13074: [Python] Deprecate ParquetDataset custom properties (eg pieces, partitions) #10549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
approved these changes
Jun 23, 2021
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1 from me. Feel free to merge if done.
Member
|
@jorisvandenbossche is there still work to do here? |
jorisvandenbossche
force-pushed
the
ARROW-13074-parquetdataset-deprecate-properties
branch
from
781ece3 to
88e7ba4
Compare
Member
Author
|
I also deprecated the manual construction of |
lidavidm
approved these changes
Jul 15, 2021
jorisvandenbossche
deleted the
ARROW-13074-parquetdataset-deprecate-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that before fully deprecating/removing the legacy implementation of
ParquetDataset, we can already deprecate its custom attributes (which is AFAIK the main/only reason to still use the legacy version).