ARROW-10440: [C++][Dataset] Visit FileWriters before Finish #10573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jun 22, 2021
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM. Looks fairly straightfoward.
This doesn't include Python bindings, which we can add in a separate ticket - that'll fully cover Lance's use case mentioned in JIRA.
Member
|
Let's leave ARROW-12364 open for the python bindings. I should be able to get to it this week. |
Member
|
Thanks Weston. I'll merge here on green (minus the known failures). |
sjperkins
pushed a commit
to sjperkins/arrow
that referenced
this pull request
Jun 23, 2021
This enables collection of paths written to during writing of a FileSystemDataset Closes apache#10573 from bkietz/10440-Add-a-callback-to-visit-f Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables collection of paths written to during writing of a FileSystemDataset