Skip to content

ARROW-11675: [CI][C++] Resolve ctest failures on VS 2019 builds #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianmcook wants to merge 13 commits into from
Closed

ARROW-11675: [CI][C++] Resolve ctest failures on VS 2019 builds #10583

ianmcook wants to merge 13 commits into from

Conversation

@ianmcook
Copy link
Member

@ianmcook ianmcook commented Jun 23, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 23, 2021

https://issues.apache.org/jira/browse/ARROW-11675

@ianmcook
Copy link
Member Author

ianmcook commented Jun 23, 2021

@github-actions crossbow submit test-build-vcpkg-win

@github-actions
Copy link

github-actions bot commented Jun 23, 2021

Revision: 877e2f829ccf2b2e892a674cb83700376f972a5d

Submitted crossbow builds: ursacomputing/crossbow @ actions-508

Task Status
test-build-vcpkg-win Github Actions

@pitrou
Copy link
Member

pitrou commented Jun 24, 2021

Wow, the build took two hours. Is there a way to make it shorter?

@pitrou
Copy link
Member

pitrou commented Jun 24, 2021

@github-actions crossbow submit test-build-vcpkg-win

@github-actions
Copy link

github-actions bot commented Jun 24, 2021

Revision: 4bf11fbd1e4c0de986cf74a029d9c6fb197ac548

Submitted crossbow builds: ursacomputing/crossbow @ actions-509

Task Status
test-build-vcpkg-win Github Actions

@pitrou
Copy link
Member

pitrou commented Jun 24, 2021

@github-actions crossbow submit test-build-vcpkg-win

@github-actions
Copy link

github-actions bot commented Jun 24, 2021

Revision: 0f36f0f8f1ec9f775105b66df31c7f492d320434

Submitted crossbow builds: ursacomputing/crossbow @ actions-510

Task Status
test-build-vcpkg-win Github Actions

@pitrou pitrou force-pushed the ARROW-11675 branch 3 times, most recently from 4df24a8 to 9b82e51 Compare June 24, 2021 14:01
@ianmcook
Copy link
Member Author

ianmcook commented Jun 24, 2021

@pitrou the manifest file cpp/vcpkg.json specifies which Arrow library build dependencies to install when ARROW_DEPENDENCY_SOURCE=VCPKG, as described in the Building Arrow C++ and Developing on Windows docs, so if you're making changes to that file, please keep in mind that it serves a general purpose beyond what this CI job tests.

@pitrou pitrou force-pushed the ARROW-11675 branch 2 times, most recently from 764fa80 to f53b013 Compare June 24, 2021 17:53
@pitrou
Copy link
Member

pitrou commented Jun 24, 2021

Yawn. When I added some logging calls inside the inner routines, the bug disappeared. Looks like a compiler bug of sorts :-(

@pitrou
Copy link
Member

pitrou commented Jun 25, 2021

TODO: perhaps add Spaced tests and specialization

@pitrou pitrou force-pushed the ARROW-11675 branch 2 times, most recently from 6416786 to 42d2df8 Compare June 28, 2021 15:30
@pitrou
Copy link
Member

pitrou commented Jun 28, 2021

@github-actions crossbow submit test-build-vcpkg-win

@pitrou pitrou marked this pull request as ready for review June 28, 2021 15:31
@github-actions
Copy link

github-actions bot commented Jun 28, 2021

Revision: 42d2df8829baa2b4af5bbf02ae4aa0993bd27b61

Submitted crossbow builds: ursacomputing/crossbow @ actions-518

Task Status
test-build-vcpkg-win Github Actions

@pitrou
Copy link
Member

pitrou commented Jun 28, 2021

@github-actions crossbow submit test-build-vcpkg-win

pitrou
pitrou reviewed Jun 28, 2021
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 28, 2021

Revision: 08ab1076947ab7fe7b778e80846704f96d5d71d2

Submitted crossbow builds: ursacomputing/crossbow @ actions-519

Task Status
test-build-vcpkg-win Github Actions

@pitrou pitrou requested a review from bkietz June 28, 2021 18:24
bkietz
bkietz approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. Otherwise this looks fine. Thanks for figuring this out

@ianmcook
Copy link
Member Author

ianmcook commented Jun 28, 2021

Thanks for working on this! The boost changes in cpp/vcpkg.json look good 👍

@pitrou
Copy link
Member

pitrou commented Jun 29, 2021

@github-actions crossbow submit test-build-vcpkg-win

@github-actions
Copy link

github-actions bot commented Jun 29, 2021

Revision: 0f6c823

Submitted crossbow builds: ursacomputing/crossbow @ actions-531

Task Status
test-build-vcpkg-win Github Actions

@pitrou
Copy link
Member

pitrou commented Jun 29, 2021

CI failures are unrelated, I'll merge.

@pitrou pitrou closed this in bf443c4 Jun 29, 2021
@asfimport asfimport mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

@bkietz bkietz bkietz approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: Parquet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook @pitrou @bkietz