-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R #10593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
refactoring the Previously altrep was only triggered when converting the arrays. This is not done in parallel because altrep allocates, but also because at least for these, it's cheap/instant. |
|
@ursabot please benchmark lang=R |
|
Benchmark runs are scheduled for baseline = 998a2a1 and contender = a85e40bfaebac5c59249e9a3dd9b4049828fd932. Results will be available as each benchmark for each run completes. |
|
@github-actions crossbow submit -g r |
|
Revision: a0f18640e86ccd4f0ef4a55ece186dc614bc7559 Submitted crossbow builds: ursacomputing/crossbow @ actions-511 |
a0f1864 to
903677e
Compare
|
I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson |
I think this can be merged and then you rebase for ARROW-13164, but I'll defer to @jonkeane to give the final 👍 and merge here, I've been out all week and haven't been keeping up with everything that's going on. |
|
Thanks @nealrichardson. @jonkeane did you have a chance to review this ? |
|
This looks good to merge. I did noticed there is one benchmark that seemed to have gotten longer (https://conbench.ursa.dev/compare/benchmarks/8cd9415be73542b5b6422f112b82ab6c...7752b1285dea4eb6b4af79a42a191189/). It's possible that won't persist, but if it does we can dig into it and address it in a follow on. |
No description provided.