Skip to content

Conversation

@romainfrancois
Copy link
Contributor

No description provided.

@github-actions
Copy link

@romainfrancois
Copy link
Contributor Author

@romainfrancois
Copy link
Contributor Author

refactoring the Table$create()and RecordBatch internals to take advantage of altrep when a column is fit for altrep (i.e. at the moment is a double array with no nulls, or an int32 array with no nulls).

Previously altrep was only triggered when converting the arrays.

This is not done in parallel because altrep allocates, but also because at least for these, it's cheap/instant.

@nealrichardson
Copy link
Member

@ursabot please benchmark lang=R

@ursabot
Copy link

ursabot commented Jun 24, 2021

Benchmark runs are scheduled for baseline = 998a2a1 and contender = a85e40bfaebac5c59249e9a3dd9b4049828fd932. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2 (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x (mimalloc)
[Skipped ⚠️ Only ['C++'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q (mimalloc)

@nealrichardson
Copy link
Member

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: a0f18640e86ccd4f0ef4a55ece186dc614bc7559

Submitted crossbow builds: ursacomputing/crossbow @ actions-511

Task Status
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
homebrew-r-autobrew Github Actions
test-r-devdocs Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-rtools-35 Github Actions
test-r-version-compatibility Github Actions
test-r-versions Github Actions
test-r-without-arrow Azure
test-ubuntu-18.04-r-sanitizer Azure

@romainfrancois
Copy link
Contributor Author

I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson

@nealrichardson
Copy link
Member

I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson

I think this can be merged and then you rebase for ARROW-13164, but I'll defer to @jonkeane to give the final 👍 and merge here, I've been out all week and haven't been keeping up with everything that's going on.

@romainfrancois
Copy link
Contributor Author

Thanks @nealrichardson. @jonkeane did you have a chance to review this ?

@jonkeane
Copy link
Member

jonkeane commented Jul 5, 2021

This looks good to merge. I did noticed there is one benchmark that seemed to have gotten longer (https://conbench.ursa.dev/compare/benchmarks/8cd9415be73542b5b6422f112b82ab6c...7752b1285dea4eb6b4af79a42a191189/). It's possible that won't persist, but if it does we can dig into it and address it in a follow on.

@jonkeane jonkeane closed this in 38b3404 Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants