ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file #10609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @westonpace |
… file Some Python versions have a bug where `signal.getsignal` creates a reference cycle holding execution frames alive (https://bugs.python.org/issue42248). This would cause excessive lifetimes of the PyArrow table returned by `read_csv`.
pitrou
force-pushed
the
ARROW-13187-signal-refcycle
branch
from
ea26d44 to
29dc65d
Compare
westonpace
approved these changes
Jun 28, 2021
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Thanks for putting this fix in! LGTM.
python/pyarrow/error.pxi
Outdated
| import os | ||
| import signal | ||
| import threading | ||
| import weakref |
Member
Author
There was a problem hiding this comment.
No, it's just a remnant from a failed attempt.
jorisvandenbossche
approved these changes
Jun 29, 2021
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
I won't say I fully understand this code ;), but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Python versions have a bug where
signal.getsignalcreates a reference cycle holding execution frames alive (https://bugs.python.org/issue42248).This would cause excessive lifetimes of the PyArrow table returned by
read_csv.