ARROW-13226: [Python] Add a general purpose cython trampolining utility #10619
Conversation
cpp/src/arrow/python/common.h
Outdated
There was a problem hiding this comment.
If this is meant to be called from arbitrary C++ code, it should probably take the GIL before anything else. Perhaps reuse SafeCallIntoPython?
There was a problem hiding this comment.
SafeCallIntoPython assumes that we're returning a Result<T> or Status, which unbound_ doesn't (it returns T or void).
Additionally, gcc4.8 cannot pass a parameter pack into a lambda
I'll use PyAcquireGIL
python/pyarrow/tests/test_dataset.py
Outdated
There was a problem hiding this comment.
Was this meant to remain commented out?
There was a problem hiding this comment.
unfortunately there's a segfault I can't track down for this non-example usage
There was a problem hiding this comment.
FYI, I merged this in and modified this part somewhat. It's working for me at #10628
|
I've used this as part of #10628 which uses it to hook metadata_collector into the file visitor. If we want to merge this separately maybe reduce the scope to be just BindFunction? |
bkietz
changed the title
|
@westonpace alright I've opened a JIRA just for BindFunction and I'll strip the dataset:: specifics |
bkietz
force-pushed
the
BindFunction-cython-utility
branch
from
c587765 to
349858d
Compare
|
+1, merging |
4 participants
No description provided.