ARROW-6312: [C++] Add support for "pkg-config --static arrow" #10626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems useful. Can we add a documentation chapter about using |
Member
Author
|
I've added a documentation about using |
Member
Author
Member
|
@kou this seems to broke the manylinux and macos wheel builds. |
Member
Author
|
Oh, sorry. I'll fix it soon. |
Member
Author
kou
added a commit
to kou/arrow
that referenced
this pull request
Feb 4, 2024
…arrow.pc
We chose Libs{,.private} with libre2.a for system RE2 in
apacheGH-10626. Because "Require{,.private} re2" may add "-std=c++11". If
"-std=c++11" was added, users can't build Apache Arrow C++ because
Apache Arrow C++ requires C++17 or later.
But this approach doesn't work with RE2 2024-06-01 or later because it
at least requires Abseil. If we keep the Libs{,.private} approach, we
also need to add Abseil libraries to Libs{,.private}. But it's
unmaintainable.
Let's use "Requires{,.private} re2" instead of Libs{,.private}. I hope
recent re2.pc doesn't add "-std=c++11".
kou
added a commit
that referenced
this pull request
Feb 5, 2024
…pc (#39932) ### Rationale for this change We chose Libs{,.private} with libre2.a for system RE2 in GH-10626. Because "Require{,.private} re2" may add "-std=c++11". If "-std=c++11" was added, users can't build Apache Arrow C++ because Apache Arrow C++ requires C++17 or later. But this approach doesn't work with RE2 2024-06-01 or later because it at least requires Abseil. If we keep the Libs{,.private} approach, we also need to add Abseil libraries to Libs{,.private}. But it's unmaintainable. ### What changes are included in this PR? Let's use "Requires{,.private} re2" instead of Libs{,.private}. I hope recent re2.pc doesn't add "-std=c++11". ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #39930 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…arrow.pc (apache#39932) ### Rationale for this change We chose Libs{,.private} with libre2.a for system RE2 in apacheGH-10626. Because "Require{,.private} re2" may add "-std=c++11". If "-std=c++11" was added, users can't build Apache Arrow C++ because Apache Arrow C++ requires C++17 or later. But this approach doesn't work with RE2 2024-06-01 or later because it at least requires Abseil. If we keep the Libs{,.private} approach, we also need to add Abseil libraries to Libs{,.private}. But it's unmaintainable. ### What changes are included in this PR? Let's use "Requires{,.private} re2" instead of Libs{,.private}. I hope recent re2.pc doesn't add "-std=c++11". ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39930 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.