Skip to content

Conversation

@jonkeane
Copy link
Member

No description provided.

@jonkeane
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

@github-actions
Copy link

Revision: 32044b313dd3caeb067f769fb5ea3bb1c6b6418f

Submitted crossbow builds: ursacomputing/crossbow @ actions-583

Task Status
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
homebrew-r-autobrew Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-rtools-35 Github Actions
test-r-ubuntu-21.04 Github Actions
test-r-version-compatibility Github Actions
test-r-versions Github Actions
test-r-without-arrow Azure
test-ubuntu-18.04-r-sanitizer Azure

@jonkeane jonkeane force-pushed the ARROW-13215-tz-in-docker branch from fd599d6 to 8a56b4d Compare July 12, 2021 17:17
@jonkeane
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: 8a56b4d52ad1633323d4b3eb0ac3df654d2b4004

Submitted crossbow builds: ursacomputing/crossbow @ actions-584

Task Status
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
homebrew-r-autobrew Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-rtools-35 Github Actions
test-r-ubuntu-21.04 Github Actions
test-r-version-compatibility Github Actions
test-r-versions Github Actions
test-r-without-arrow Azure
test-ubuntu-18.04-r-sanitizer Azure

@rok
Copy link
Member

rok commented Jul 12, 2021

Would it be possible to accomplish this with Sys.setenv and test behavior in multiple timezones?

@jonkeane
Copy link
Member Author

This is actually attempting to resolve a nuisance message in the CI logs — but with the way it is setup, we should be able to set this to something other than UTC for one of the builds such that we can confirm that this works in timezones other than UTC.

We already have some ad-hoc testing of the like (

test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", {
# Write a feather file as that's what the initial bug report used
df <- tibble::tibble(
no_tz = lubridate::ymd_hms("2018-10-07 19:04:05") + 1:10,
yes_tz = lubridate::ymd_hms("2018-10-07 19:04:05", tz = "Asia/Pyongyang") + 1:10
)
if (!identical(Sys.timezone(), "Asia/Pyongyang")) {
# Confirming that the columns are in fact different
expect_false(any(df$no_tz == df$yes_tz))
}
feather_file <- tempfile()
on.exit(unlink(feather_file))
write_feather(df, feather_file)
expect_identical(read_feather(feather_file), df)
})
)

@rok
Copy link
Member

rok commented Jul 12, 2021

Ah, got it. I thought this was related to ARROW-12994. Never mind :).

@jonkeane jonkeane changed the title ARROW-13215: [R] [CI] Add ENV TZ to docker files? [WIP] ARROW-13215: [R] [CI] Add ENV TZ to docker files? Jul 12, 2021
@thisisnic
Copy link
Member

Great idea, much simpler than the other workarounds for this

@jonkeane jonkeane force-pushed the ARROW-13215-tz-in-docker branch from c0ceb2c to f2e776d Compare July 13, 2021 15:39
jonkeane and others added 2 commits July 13, 2021 10:50
Co-authored-by: Rok Mihevc <rok@mihevc.org>
@jonkeane
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: 20ba50f

Submitted crossbow builds: ursacomputing/crossbow @ actions-589

Task Status
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
homebrew-r-autobrew Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-rtools-35 Github Actions
test-r-ubuntu-21.04 Github Actions
test-r-version-compatibility Github Actions
test-r-versions Github Actions
test-r-without-arrow Azure
test-ubuntu-18.04-r-sanitizer Azure

@jonkeane jonkeane requested a review from nealrichardson July 14, 2021 13:49
@nealrichardson nealrichardson changed the title ARROW-13215: [R] [CI] Add ENV TZ to docker files? ARROW-13215: [R] [CI] Add ENV TZ to docker files Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants