Skip to content

ARROW-13164: [R] altrep vectors from Array with nulls #10730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
romainfrancois wants to merge 32 commits into from
Closed

ARROW-13164: [R] altrep vectors from Array with nulls #10730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
8e081a6
+ UseSentinel()
romainfrancois Jun 24, 2021
9b117cd
skip tests for now, unrelated to the business of the PR
romainfrancois Jul 2, 2021
5e5f61a
Use altrep always for int32 and double array for which the data is mu…
romainfrancois Jul 2, 2021
7038708
use the sentinel in parallel
romainfrancois Jul 2, 2021
39a28c1
skeleton for Min/Max/Sum methods for altrep vectors int32/double
romainfrancois Jul 6, 2021
f3686a2
use arrow::compute::CallFunction() for min and max of altrep vectors
romainfrancois Jul 16, 2021
fffd358
factor out options
romainfrancois Jul 16, 2021
cc25d02
use Base consistently
romainfrancois Jul 16, 2021
78e2a76
Update r/src/array_to_vector.cpp
romainfrancois Jul 16, 2021
7b19de9
Update r/src/altrep.cpp
romainfrancois Jul 16, 2021
739a059
use cpp11::na
romainfrancois Jul 16, 2021
b934452
lint
romainfrancois Jul 16, 2021
039f049
factor out CanAltrep()
romainfrancois Jul 19, 2021
f5acd60
tests for min/max/sum
romainfrancois Jul 19, 2021
16f4302
Update r/src/altrep.cpp
romainfrancois Jul 19, 2021
97635bb
additional test for sum() -> INT_MIN
romainfrancois Jul 19, 2021
9043109
factor out and improve expect_altrep_roudtrip()
romainfrancois Jul 19, 2021
679da88
refactoring altrep code
romainfrancois Aug 17, 2021
6b44919
fusion altrep classes
romainfrancois Aug 19, 2021
3c6d526
uncomment tests
romainfrancois Aug 19, 2021
49a2265
specific warning text
romainfrancois Aug 19, 2021
5f34a27
remove dead CanAltrep() method
romainfrancois Aug 19, 2021
0c3c109
Slice() gives a new Array, so not using a const reference.
romainfrancois Aug 19, 2021
ed108cb
more comments
romainfrancois Aug 19, 2021
53f8859
Implement Dataptr(writeable = TRUE).
romainfrancois Aug 27, 2021
6b49b4e
Materialize() no longer sets data2 to be immutable.
romainfrancois Aug 27, 2021
8517511
make the altrep object not mutable again
romainfrancois Aug 30, 2021
2d9e1ad
Min/Max/Sum unconditionally using the Array again
romainfrancois Aug 30, 2021
83dcad9
+ Is_sorted()
romainfrancois Aug 31, 2021
60b6d89
lint
romainfrancois Aug 31, 2021
fe15fbd
+ Unserialize() / Serialized_state() methods
romainfrancois Aug 31, 2021
763781c
+ Coerce() skeleton
romainfrancois Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions r/R/arrowExports.R
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion r/data-raw/codegen.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ glue::glue('\n
R_useDynamicSymbols(dll, FALSE);

#if defined(ARROW_R_WITH_ARROW) && defined(HAS_ALTREP)
arrow::r::Init_Altrep_classes(dll);
arrow::r::altrep::Init_Altrep_classes(dll);
#endif

}
Expand Down
Loading