ARROW-13384: [C++] Specify minimum required zstd version in cmake #10747

nealrichardson · 2021-07-19T17:29:02Z

No description provided.

nealrichardson · 2021-07-19T17:29:19Z

@github-actions crossbow submit homebrew-r-autobrew

github-actions · 2021-07-19T17:29:22Z

https://issues.apache.org/jira/browse/ARROW-13384

nealrichardson · 2021-07-19T17:29:49Z

^ that should fail but should fail differently: it should say that the version requirement isn't met. Then once the bottle is upgraded, it should work on retry.

github-actions · 2021-07-19T17:30:09Z

Revision: 316d4b241710e931acc17905c1b5a8d6a3ac6278

Submitted crossbow builds: ursacomputing/crossbow @ actions-613

Task	Status
homebrew-r-autobrew

kszucs · 2021-07-19T18:11:46Z

There are more failing builds: #10659 (comment)

Interestingly the debian 10 based builds have ZSTD with version 1.3.8 but the issue is still there: https://github.com/ursacomputing/crossbow/runs/3106411669?check_suite_focus=true#step:8:316

kszucs · 2021-07-19T18:13:38Z

@github-actions crossbow submit test-debian-10-cpp

github-actions · 2021-07-19T18:14:38Z

Revision: ddc76aef0747ef25e73408a69e2c037d5ceefa89

Submitted crossbow builds: ursacomputing/crossbow @ actions-615

Task	Status
test-debian-10-cpp

nealrichardson · 2021-07-19T18:18:30Z

The autobrew job didn't fail as expected, maybe cmake found something newer on the system but then still used the old 1.3.5 when compiling?

kszucs · 2021-07-19T18:31:40Z

The API has been stabilized at 1.4.0, see facebook/zstd@d7d8951#diff-e51691a217ef645007ebc5dd6db0539c32d0a531aad5823873adb12d995341b5R177

kszucs · 2021-07-19T18:34:21Z

@github-actions crossbow submit test-debian-10-cpp homebrew-r-autobrew

github-actions · 2021-07-19T18:35:20Z

Revision: dc521704f9a7a4876e8069f44bc4cb712597b8fb

Submitted crossbow builds: ursacomputing/crossbow @ actions-616

Task	Status
homebrew-r-autobrew
test-debian-10-cpp

kszucs · 2021-07-19T18:47:48Z

@github-actions crossbow submit test-ubuntu-* test-debian-*

github-actions · 2021-07-19T18:48:41Z

Revision: e27a2210ad030ae60669c4bab480d2ad117a92a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-617

Task	Status
test-debian-10-cpp
test-debian-10-go-1.15
test-debian-10-python-3
test-debian-c-glib
test-debian-ruby
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-18.04-python-3
test-ubuntu-18.04-r-sanitizer
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-14
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.10-docs
test-ubuntu-c-glib
test-ubuntu-default-docs
test-ubuntu-ruby

kszucs · 2021-07-19T18:57:50Z

@github-actions crossbow submit ubuntu-bionic-* debian-buster-*

github-actions · 2021-07-19T18:58:41Z

Revision: 947c9dafee1de5671e7a92ea88458ca1f6902f58

Submitted crossbow builds: ursacomputing/crossbow @ actions-618

Task	Status
debian-buster-amd64
debian-buster-arm64
ubuntu-bionic-amd64
ubuntu-bionic-arm64

kszucs · 2021-07-19T20:30:47Z

@kou can we make both utcf8proc and zstd optional at this line?

kou · 2021-07-19T20:48:40Z

Could you try the following? It's dirty but will work...

diff --git a/dev/tasks/linux-packages/apache-arrow/debian/libarrow-dev.install b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-dev.install
index 83ddad126..ccd0c4e5b 100644
--- a/dev/tasks/linux-packages/apache-arrow/debian/libarrow-dev.install
+++ b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-dev.install
@@ -6,8 +6,7 @@ usr/lib/*/cmake/arrow/Find*Alt.cmake
 usr/lib/*/cmake/arrow/FindArrow.cmake
 usr/lib/*/cmake/arrow/FindBrotli.cmake
 usr/lib/*/cmake/arrow/FindLz4.cmake
-usr/lib/*/cmake/arrow/FindSnappy.cmake
-usr/lib/*/cmake/arrow/Find[uz]*.cmake
+usr/lib/*/cmake/arrow/Find[Suz]*.cmake
 usr/lib/*/cmake/arrow/arrow-config.cmake
 usr/lib/*/libarrow.a
 usr/lib/*/libarrow.so

kou · 2021-07-19T20:55:00Z

@github-actions crossbow submit amazon-linux-* centos-*

github-actions · 2021-07-19T20:55:55Z

Revision: 947c9dafee1de5671e7a92ea88458ca1f6902f58

Submitted crossbow builds: ursacomputing/crossbow @ actions-620

Task	Status
amazon-linux-2-amd64
centos-7-amd64
centos-8-amd64
centos-8-arm64

kszucs · 2021-07-19T21:24:39Z

@github-actions crossbow submit ubuntu-bionic-* debian-buster-*

github-actions · 2021-07-19T21:25:38Z

Revision: 4084657e8ab1f7f92decd1a6125cffbd197f605b

Submitted crossbow builds: ursacomputing/crossbow @ actions-621

Task	Status
debian-buster-amd64
debian-buster-arm64
ubuntu-bionic-amd64
ubuntu-bionic-arm64

kszucs · 2021-07-19T21:32:19Z

@github-actions crossbow submit amazon-linux-* centos-*

github-actions · 2021-07-19T21:33:09Z

Revision: 536b8ed8e3a4f7d9d4a1e7c5b7a56fff135031bb

Submitted crossbow builds: ursacomputing/crossbow @ actions-622

Task	Status
amazon-linux-2-amd64
centos-7-amd64
centos-8-amd64
centos-8-arm64

kszucs · 2021-07-19T22:00:06Z

@github-actions crossbow submit amazon-linux-2-amd64

github-actions · 2021-07-19T22:00:56Z

Revision: 9ec7e7afa1e7bb6185f5c199dbb0f875607d8df6

Submitted crossbow builds: ursacomputing/crossbow @ actions-623

Task	Status
amazon-linux-2-amd64

kszucs · 2021-07-19T22:19:56Z

@github-actions crossbow submit -g nightly

github-actions · 2021-07-19T22:21:06Z

Revision: 8370e80

Submitted crossbow builds: ursacomputing/crossbow @ actions-624

Task	Status
centos-7-amd64
centos-8-amd64
centos-8-arm64
conda-clean
conda-linux-gcc-py36-arm64
conda-linux-gcc-py36-cpu-r40
conda-linux-gcc-py36-cuda
conda-linux-gcc-py37-arm64
conda-linux-gcc-py37-cpu-r41
conda-linux-gcc-py37-cuda
conda-linux-gcc-py38-arm64
conda-linux-gcc-py38-cpu
conda-linux-gcc-py38-cuda
conda-linux-gcc-py39-arm64
conda-linux-gcc-py39-cpu
conda-linux-gcc-py39-cuda
conda-osx-arm64-clang-py38
conda-osx-arm64-clang-py39
conda-osx-clang-py36-r40
conda-osx-clang-py37-r41
conda-osx-clang-py38
conda-osx-clang-py39
conda-win-vs2017-py36-r40
conda-win-vs2017-py37-r41
conda-win-vs2017-py38
conda-win-vs2017-py39
debian-bullseye-amd64
debian-bullseye-arm64
debian-buster-amd64
debian-buster-arm64
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
homebrew-cpp
homebrew-r-autobrew
java-jars
nuget
python-sdist
test-build-vcpkg-win
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.6
test-conda-python-3.6-pandas-0.23
test-conda-python-3.7
test-conda-python-3.7-dask-latest
test-conda-python-3.7-dask-master
test-conda-python-3.7-hdfs-2.9.2
test-conda-python-3.7-hdfs-3.2.1
test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
test-conda-python-3.7-pandas-0.24
test-conda-python-3.7-pandas-latest
test-conda-python-3.7-spark-branch-3.0
test-conda-python-3.7-turbodbc-latest
test-conda-python-3.7-turbodbc-master
test-conda-python-3.8
test-conda-python-3.8-hypothesis
test-conda-python-3.8-pandas-latest
test-conda-python-3.8-pandas-nightly
test-conda-python-3.8-spark-master
test-conda-python-3.9
test-conda-python-3.9-pandas-master
test-debian-10-cpp
test-debian-10-go-1.15
test-debian-10-python-3
test-debian-c-glib
test-debian-ruby
test-fedora-33-cpp
test-fedora-33-python-3
test-r-devdocs
test-r-gcc-11
test-r-install-local
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-rhub-ubuntu-gcc-release-latest
test-r-rocker-r-base-latest
test-r-rstudio-r-base-3.6-bionic
test-r-rstudio-r-base-3.6-centos7-devtoolset-8
test-r-rstudio-r-base-3.6-centos8
test-r-rstudio-r-base-3.6-opensuse15
test-r-rstudio-r-base-3.6-opensuse42
test-r-rtools-35
test-r-ubuntu-21.04
test-r-version-compatibility
test-r-versions
test-r-without-arrow
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-18.04-python-3
test-ubuntu-18.04-r-sanitizer
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-14
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.10-docs
test-ubuntu-c-glib
test-ubuntu-default-docs
test-ubuntu-ruby
ubuntu-bionic-amd64
ubuntu-bionic-arm64
ubuntu-focal-amd64
ubuntu-focal-arm64
ubuntu-groovy-amd64
ubuntu-groovy-arm64
ubuntu-hirsute-amd64
ubuntu-hirsute-arm64
wheel-macos-big-sur-cp39-arm64
wheel-macos-big-sur-cp39-universal2
wheel-macos-high-sierra-cp36-amd64
wheel-macos-high-sierra-cp37-amd64
wheel-macos-high-sierra-cp38-amd64
wheel-macos-high-sierra-cp39-amd64
wheel-macos-mavericks-cp36-amd64
wheel-macos-mavericks-cp37-amd64
wheel-macos-mavericks-cp38-amd64
wheel-macos-mavericks-cp39-amd64
wheel-manylinux2010-cp36-amd64
wheel-manylinux2010-cp37-amd64
wheel-manylinux2010-cp38-amd64
wheel-manylinux2010-cp39-amd64
wheel-manylinux2014-cp36-amd64
wheel-manylinux2014-cp36-arm64
wheel-manylinux2014-cp37-amd64
wheel-manylinux2014-cp37-arm64
wheel-manylinux2014-cp38-amd64
wheel-manylinux2014-cp38-arm64
wheel-manylinux2014-cp39-amd64
wheel-manylinux2014-cp39-arm64
wheel-windows-cp36-amd64
wheel-windows-cp37-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64