-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-13399: [R] Update dataset.Rmd vignette #10765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9929e55
Remove backticks to make easier to read
thisisnic fbe7466
Grammarly suggestions and adding some subheadings
thisisnic 9726952
"we" -> "you"
thisisnic e13543d
Use bold instead of backticks to make package names more readable
thisisnic a941444
Split paragraph into bullets
thisisnic 02ffc4c
Breaking sections down and tweaks
thisisnic ae9b685
Rename section heading
thisisnic 2c4f9f4
Specify Windows version for S3, minor tweaks
thisisnic 52ec5f6
Update r/vignettes/dataset.Rmd
thisisnic 254771f
Remove highlighting of arrow/dplyr to make easier to read and more li…
thisisnic ff09054
Remove extra backticks on Arrow object names
thisisnic 4ee3b42
Remove unnecessary "Arrow"
thisisnic 9df7b5c
Remove unnecessary hyphens
thisisnic 5cb9469
"a" -> "an"
thisisnic 40860cf
Make explanation more explicit
thisisnic df69b6d
Stylistic change
thisisnic 5c415c3
Add STYLE.md
thisisnic f8ab48a
Update style file to make clearer
thisisnic c7052f9
Explicitly reference supported parsing options
thisisnic f065df2
Tweak STYLE.md and its examples
thisisnic c150bbc
Use headings
thisisnic 88b63ae
"for" -> "to"
thisisnic b5f75b7
Pedantry
thisisnic 1bb3c88
add ASF header
thisisnic be3e7bb
Delete sentence
thisisnic 5c5b60a
Merge branch 'master' into ARROW_13399_dataset_vignette
thisisnic feed3b5
Update .Rbuildignore
thisisnic 6666c13
Update r/STYLE.md
thisisnic 0cde04f
Update r/vignettes/dataset.Rmd
thisisnic 9873808
Update r/vignettes/dataset.Rmd
thisisnic 52a66f8
Update r/vignettes/dataset.Rmd
thisisnic 1a4ff1d
Update r/vignettes/dataset.Rmd
thisisnic 8ba084c
Update r/vignettes/dataset.Rmd
thisisnic b4ea47b
Update r/vignettes/dataset.Rmd
thisisnic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,4 +24,5 @@ clang_format.sh | |
| ^apache-arrow.rb$ | ||
| ^.*\.Rhistory$ | ||
| ^extra-tests | ||
| STYLE.md | ||
| ^.lintr | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <!--- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| # Style | ||
|
|
||
| This is a style guide to writing documentation for arrow. | ||
|
|
||
| ## Coding style | ||
|
|
||
| Please use the [tidyverse coding style](https://style.tidyverse.org/). | ||
|
|
||
| ## Referring to external packages | ||
|
|
||
| When referring to external packages, include a link to the package at the first mention, and subsequently refer to it in plain text, e.g. | ||
|
|
||
| * "The arrow R package provides a [dplyr](https://dplyr.tidyverse.org/) interface to Arrow Datasets. This vignette introduces Datasets and shows how to use dplyr to analyze them." | ||
|
|
||
| ## Data frames | ||
|
|
||
| When referring to the concept, use the phrase "data frame", whereas when referring to an object of that class or when the class is important, write `data.frame`, e.g. | ||
|
|
||
| * "You can call `write_dataset()` on tabular data objects such as Arrow Tables or RecordBatches, or R data frames. If working with data frames you might want to use a `tibble` instead of a `data.frame` to take advantage of the default behaviour of partitioning data based on grouped variables." | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.