ARROW-13519: [R] Make doc examples less noisy #10851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@nealrichardson - please can you take a look at this one and let me know what you think; wasn't sure how exactly to strike the balance between assigning the output of some examples to reduce output vs. doing it on too many where it wouldn't make sense. Is there a rough heuristic I can use to assess this? |
r/R/compute.R
Outdated
Member
There was a problem hiding this comment.
I would just let this print except that the StructArray print method is ugly.
nealrichardson
approved these changes
Aug 3, 2021
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
One suggestion but LGTM otherwise, thanks
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
nealrichardson
force-pushed
the
ARROW-13519_noisy_docs
branch
from
7825af3 to
1ab6138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.