Skip to content

Conversation

@rommelDB
Copy link
Contributor

@rommelDB rommelDB commented Aug 4, 2021

Changes:

  • Implemented casting support from date32/date64 to uft8/large_utf8
  • Added unit tests for converting from date32/date64 to uft8/large_utf8.

…nted the casting support from date32/date64 to uft8/large_utf8
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

@rommelDB
Copy link
Contributor Author

rommelDB commented Aug 4, 2021

@bkietz please, have a look to this PR

@lidavidm
Copy link
Member

lidavidm commented Aug 5, 2021

Looks like there are some lint failures - you can fix them locally as described at https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci or by commenting @github-actions autotune in this PR.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I left a comment about the FIXME.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will merge on green.

@lidavidm
Copy link
Member

lidavidm commented Aug 5, 2021

(Well, if you don't plan on adding more - feel free to mark ready for review)

@rommelDB rommelDB marked this pull request as ready for review August 5, 2021 16:12
@rommelDB
Copy link
Contributor Author

rommelDB commented Aug 5, 2021

LGTM, thanks! Will merge on green.

Thank you so much David! I will be aware of the CI output.

@lidavidm
Copy link
Member

lidavidm commented Aug 5, 2021

I think the failures here are flukes (GHA seems to be having a bit of trouble), let's see when the Travis build finishes.

@lidavidm lidavidm closed this in a669ac5 Aug 5, 2021
@nealrichardson
Copy link
Member

Thanks for doing this! 🙏 In the future, it can be a good idea to grep the source for the Jira issue number to see if there are any TODOs or skipped tests related to the issue. There was one in the R test suite from when the issue was originally reported; I've removed it in #10891.

@rommelDB
Copy link
Contributor Author

rommelDB commented Aug 6, 2021

Thanks for doing this! pray In the future, it can be a good idea to grep the source for the Jira issue number to see if there are any TODOs or skipped tests related to the issue. There was one in the R test suite from when the issue was originally reported; I've removed it in #10891.

Yes, I totally agree with you, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants