ARROW-13562: [R] Styler followups

[nealrichardson]

Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-13562

[jonkeane]

We don't have to do this here, but given all where we are putting them, I wonder if we want to make (or investigate if this exists in styler already...) a file in r/arrow that specifies which files are no-style so we only have one place we need it

[jonkeane]

Turns out styler doesn't have this, though they are considering ways to do it. r-lib/styler#319

We could add our own and "just" source that file that lists the files we want to skip so that we only have to list them once.

[lorenzwalthert]

Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code.

Hi @nealrichardson, can you maybe tell us a bit more about problems with that so we could improve that?

[nealrichardson]

Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code.

Hi @nealrichardson, can you maybe tell us a bit more about problems with that so we could improve that?

@lorenzwalthert the first thing I found was that, while style-on-save would clearly do something (like remove extra whitespace), I was still getting lint warnings about files not having a trailing newline. I didn't get this if I just ran styler directly on the file. Later, it seemed like the style-on-save wasn't firing at all. I figured it was possible that either of those could just be user error, and I wanted a simple (to me) way to re-style all of the files anyway, so I added these make commands. If it would be helpful, I'm happy to write an issue somewhere.

[lorenzwalthert]

Thanks @nealrichardson. I referenced your comment in an open issue (REditorSupport/languageserver#462), I hope this gets resolved. Regarding that formatting wasn't fired at all, I am unsure what the problem was. Just noted several issues in the above repo where the problem was the fact that styler is quite slow on unseen code (r-lib/styler#558).