ARROW-13544 [Java]: Remove APIs that have been deprecated for long (Changes to ArrowBuf) #10901
Conversation
…hanges to ArrowBuf)
| ) { | ||
| int [] intValues = new int [] {Integer.MAX_VALUE, Integer.MIN_VALUE, 0}; | ||
| for (int val : intValues) { | ||
| buf.clear(); |
There was a problem hiding this comment.
given these changes, I think maybe we should keep clear() and remove all the rest. adding more calls for readerIndex and writeIndex seems like it is moving in the wrong direction.
There was a problem hiding this comment.
sounds good. I have revised the PR to preserve the method.
|
CC @jacques-n not sure if there is a current point of contact at dremio, but I'm incline to start removing the deprecated methods here that were used as a crutch for some prior cleanup. I'll merge early next week unless there are objections. |
I'd suspect that @vvellanki, @laurentgo, @StevenMPhillips and @pravindra should be able to provide better insights on these objections. |
|
@emkornfield you should proceed. We had enough time to modify our own code, and if we still have some references left, that's on us. |
…hanges to ArrowBuf) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to `ArrowBuf` Closes apache#10901 from liyafan82/fly_0810_dep Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
…hanges to ArrowBuf) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to `ArrowBuf` Closes apache#10901 from liyafan82/fly_0810_dep Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
4 participants
See https://issues.apache.org/jira/browse/ARROW-13544
According to the discussion in #10864 (comment), we want to split the task into multiple parts.
This PR is for the changes related to
ArrowBuf