ARROW-13544 [Java]: Remove APIs that have been deprecated for long (Changes to JDBC) #10912
Conversation
| * @throws SQLException Propagate any SQL Exceptions to the caller after closing any resources opened such as | ||
| * ResultSet and Statement objects. | ||
| */ | ||
| public static VectorSchemaRoot sqlToArrow(Connection connection, String query, BufferAllocator allocator) |
There was a problem hiding this comment.
It seems ashame to simply do a code move here, would it make sense to make the deprecated methods package private instead and commnent that they are test only?
I think this also reminds me that the model for the iteration here doesn't match the Loader/Unloader pattern but creates a new VectorSchemaRoot each time (I might be misremembering though)
There was a problem hiding this comment.
It seems ashame to simply do a code move here, would it make sense to make the deprecated methods package private instead and commnent that they are test only?
I think it is a good idea to explicitly state that these methods are for test only. However, it is not feasible to declare them as package private, as they are used in at least two packages: org.apache.arrow.adapter.jdbc and org.apache.arrow.adapter.jdbc.h2.
I think this also reminds me that the model for the iteration here doesn't match the Loader/Unloader pattern but creates a new VectorSchemaRoot each time (I might be misremembering though)
I think you are right
|
CC @xhochy I think last time we talked about this you were able to use the undeprecated methods, just wanted to make sure this is still the case or you have a migration plan. |
|
+1 thank you. |
…hanges to JDBC) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to the JDBC adapter Closes apache#10912 from liyafan82/fly_0811_depj Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
…hanges to JDBC) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to the JDBC adapter Closes apache#10912 from liyafan82/fly_0811_depj Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
2 participants
See https://issues.apache.org/jira/browse/ARROW-13544
According to the discussion in #10864 (comment), we want to split the task into multiple parts.
This PR is for the changes related to the JDBC adapter