Skip to content

Conversation

@lidavidm
Copy link
Member

No description provided.

@github-actions
Copy link

@pitrou
Copy link
Member

pitrou commented Aug 19, 2021

The changes here seem to include some of the changes in #10942?

@lidavidm
Copy link
Member Author

The changes here seem to include some of the changes in #10942?

I tried to reconcile them a little bit ahead of time to make my life easier since they will conflict on merge.

@lidavidm
Copy link
Member Author

I'm going to move this to draft since I'd rather we get #10942 in first; there's going to be a lot of rebasing work I fear.

@lidavidm lidavidm marked this pull request as draft August 19, 2021 19:16
@pitrou
Copy link
Member

pitrou commented Aug 24, 2021

Do you want to undraft this now?

@lidavidm
Copy link
Member Author

Sorry, yes, let me rebase and undraft. Thanks for the reminder.

@lidavidm lidavidm marked this pull request as ready for review August 24, 2021 19:04
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants