Skip to content

ARROW-13548: [C++] Implement temporal difference kernels #10960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 4 commits into from
Closed

ARROW-13548: [C++] Implement temporal difference kernels #10960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7124872
ARROW-13548: [C++] Implement temporal difference kernels
lidavidm Aug 17, 2021
7ed878b
ARROW-13548: [C++] Implement temporal difference kernels for dates, t…
lidavidm Sep 28, 2021
9d0a83a
ARROW-13548: [C++] Update docs
lidavidm Sep 28, 2021
e24f393
ARROW-13548: [C++] Fix suggestions
lidavidm Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/array/diff.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ class MakeFormatterImpl {
impl_ = [](const Array& array, int64_t index, std::ostream* os) {
auto month_day_nanos =
checked_cast<const MonthDayNanoIntervalArray&>(array).Value(index);
*os << month_day_nanos.months << "m" << month_day_nanos.days << "d"
*os << month_day_nanos.months << "M" << month_day_nanos.days << "d"
<< month_day_nanos.nanoseconds << "ns";
};
return Status::OK();
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/array/diff_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ TEST_F(DiffTest, UnifiedDiffFormatter) {
target_ = ArrayFromJSON(month_day_nano_interval(), R"([])");
AssertDiffAndFormat(R"(
@@ -0, +0 @@
-2m3d1ns
-2M3d1ns
)");

// lists
Expand Down
4 changes: 4 additions & 0 deletions cpp/src/arrow/compute/kernels/codegen_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,10 @@ using ScalarBinaryEqualTypes = ScalarBinary<OutType, ArgType, ArgType, Op>;
template <typename OutType, typename ArgType, typename Op>
using ScalarBinaryNotNullEqualTypes = ScalarBinaryNotNull<OutType, ArgType, ArgType, Op>;

template <typename OutType, typename ArgType, typename Op>
using ScalarBinaryNotNullStatefulEqualTypes =
ScalarBinaryNotNullStateful<OutType, ArgType, ArgType, Op>;

} // namespace applicator

// ----------------------------------------------------------------------
Expand Down
Loading