ARROW-13904: [R] Implement ModeOptions #11092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Sep 6, 2021
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
A quick review on the C++ part. I won't comment on the R tests.
r/src/compute.cpp
Outdated
| using Options = arrow::compute::ModeOptions; | ||
| auto out = std::make_shared<Options>(Options::Defaults()); | ||
| if (!Rf_isNull(options["n"])) { | ||
| out->n = cpp11::as_cpp<int>(options["n"]); |
Member
There was a problem hiding this comment.
ModeOptions::n is an int64_t, so perhaps use cpp11::as_cpp<int64_t>?
Member
Author
There was a problem hiding this comment.
Cheers for spotting that, will update them both!
r/src/compute.cpp
Outdated
| out->n = cpp11::as_cpp<int>(options["n"]); | ||
| } | ||
| if (!Rf_isNull(options["min_count"])) { | ||
| out->min_count = cpp11::as_cpp<int>(options["min_count"]); |
Member
There was a problem hiding this comment.
For the same reason, perhaps cpp11::as_cpp<uint32_t>.
nealrichardson
approved these changes
Sep 9, 2021
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Closes apache#11092 from thisisnic/ARROW-13904_modeoptions Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.