Skip to content

ARROW-13908: [R] Implement ExtractRegexOptions #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thisisnic wants to merge 2 commits into from
Closed

ARROW-13908: [R] Implement ExtractRegexOptions #11098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e167b
Implement ExtractRegexOptions
thisisnic Sep 6, 2021
7f8889f
Relint
thisisnic Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions r/src/compute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,11 @@ std::shared_ptr<arrow::compute::FunctionOptions> make_compute_options(
max_replacements);
}

if (func_name == "extract_regex") {
using Options = arrow::compute::ExtractRegexOptions;
return std::make_shared<Options>(cpp11::as_cpp<std::string>(options["pattern"]));
}

if (func_name == "day_of_week") {
using Options = arrow::compute::DayOfWeekOptions;
bool one_based_numbering = true;
Expand Down
8 changes: 8 additions & 0 deletions r/tests/testthat/test-compute-no-bindings.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,11 @@ test_that("non-bound compute kernels using MatchSubstringOptions", {
c(0, 0, 1, 1)
)
})

test_that("non-bound compute kernels using ExtractRegexOptions", {
skip_if_not_available("re2")
expect_equal(
call_function("extract_regex", Scalar$create("abracadabra"), options = list(pattern = "(?P<letter>[a])")),
Scalar$create(tibble::tibble(letter = "a"))
)
})