Skip to content

ARROW-13842: [C++] Bump vendored date library #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-13842: [C++] Bump vendored date library #11117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cpp/src/arrow/pretty_print_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ TEST_F(TestPrettyPrint, DateTimeTypesWithOutOfRangeValues) {
CheckPrimitive<TimestampType, int64_t>(timestamp(TimeUnit::MICRO), {0, 10}, is_valid,
values, expected);
}
#ifndef ARROW_UBSAN
// While the values below are legal and correct, they trigger an internal
// signed overflow inside the arrow_vendored::date library.
// Note that while the values below are legal and correct, they used to
// trigger an internal signed overflow inside the vendored "date" library
// (https://github.com/HowardHinnant/date/issues/696).
{
std::vector<int64_t> values = {min_int64, max_int64};
static const char* expected = R"expected([
Expand All @@ -463,7 +463,6 @@ TEST_F(TestPrettyPrint, DateTimeTypesWithOutOfRangeValues) {
CheckPrimitive<TimestampType, int64_t>(timestamp(TimeUnit::NANO), {0, 10},
{true, true}, values, expected);
}
#endif
}

TEST_F(TestPrettyPrint, StructTypeBasic) {
Expand Down
9 changes: 8 additions & 1 deletion cpp/src/arrow/vendored/datetime/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,12 @@ copies or substantial portions of the Software.
Sources for datetime are adapted from Howard Hinnant's date library
(https://github.com/HowardHinnant/date).

Sources are taken from v3.0.0 release of the above project.
Sources are taken from changeset 2e19c006e2218447ee31f864191859517603f59f
of the above project.

The following changes are made:
- fix internal inclusion paths (from "date/xxx.h" to simply "xxx.h")
- enclose the `date` namespace inside the `arrow_vendored` namespace
- include a custom "visibility.h" header from "tz.cpp" for proper DLL
exports on Windows
- disable curl-based database downloading in "tz.h"
Loading