ARROW-12871: [R] upgrade to testthat 3e

[nealrichardson]

I've currently made it up through the dplyr tests, so lots more to go. Most changes are not substantive but there have been a few where the tests weren't doing exactly what we thought they were, and this exposed them.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-12871

[nealrichardson]

@github-actions crossbow submit -g r

[github-actions]

Revision: 831f39408a24e88a58e4ced34f8abe0bc2614e18

Submitted crossbow builds: ursacomputing/crossbow @ actions-854

Task	Status
conda-linux-gcc-py36-cpu-r40
conda-linux-gcc-py37-cpu-r41
conda-osx-clang-py36-r40
conda-osx-clang-py37-r41
conda-win-vs2017-py36-r40
conda-win-vs2017-py37-r41
homebrew-r-autobrew
test-r-depsource-auto
test-r-depsource-system
test-r-devdocs
test-r-gcc-11
test-r-install-local
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc-release-latest
test-r-rocker-r-base-latest
test-r-rstudio-r-base-3.6-bionic
test-r-rstudio-r-base-3.6-centos7-devtoolset-8
test-r-rstudio-r-base-3.6-centos8
test-r-rstudio-r-base-3.6-opensuse15
test-r-rstudio-r-base-3.6-opensuse42
test-r-ubuntu-21.04
test-r-version-compatibility
test-r-versions
test-ubuntu-18.04-r-sanitizer

[jonkeane]

This looks great. I've made two small comments. I presume the windows failures (it looks like all with timezone issues?) were there already we were ignoring (all) attributes before (it doesn't look like check.tzone gets passed through waldo)

[jonkeane]

This is minor, but I wonder if we should take this opportunity to rename this expect_as_vector_equal to be super clear we are expecting them to be equal (via as.vector())

[nealrichardson]

This looks great. I've made two small comments. I presume the windows failures (it looks like all with timezone issues?) were there already we were ignoring (all) attributes before (it doesn't look like check.tzone gets passed through waldo)

check.tzone is an argument to all.equal(), which waldo replaces. We need to instead pass ignore_attr = "tzone", which I did in the places that failed for me locally. Need to inspect the windows failures (now that they finally did not time out) to see why they need this added now.

[jonkeane]

Rok ran into issues with timezones on windows when working on strftime which might be related: https://issues.apache.org/jira/browse/ARROW-13168 (and to a lesser extent, but could be related: #11105 (comment))

[nealrichardson]

The windows failures are actually ARROW-13588, which I think we're seeing here because of a difference between waldo and base::all.equal

[jonkeane]

The windows failures are actually ARROW-13588, which I think we're seeing here because of a difference between waldo and base::all.equal

😂 / 😭