Skip to content

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented Sep 22, 2021

VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support.

See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3E

@bkietz bkietz requested review from ianmcook and pitrou September 22, 2021 15:39
@github-actions
Copy link

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :-)

appveyor.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this one but switch to a newer VS? It also differs by not using conda packages for dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created https://issues.apache.org/jira/browse/ARROW-14075 to add vs2019 and non-conda jobs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this causes an exit-with-error-code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need exit /B 1 for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice.

@pitrou
Copy link
Member

pitrou commented Sep 22, 2021

@github-actions crossbow submit win

@github-actions
Copy link

Revision: 6c96be131565277598667e6c8082b4878e5fa6bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-853

Task Status
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
conda-win-vs2017-py38 Azure
conda-win-vs2017-py39 Azure
test-build-vcpkg-win Github Actions
verify-rc-source-windows Github Actions
verify-rc-wheels-windows Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kszucs
Copy link
Member

kszucs commented Sep 22, 2021

The verification tasks require additional prams and the vcpkg task is failing regardless of the PR (based on the nightly report).

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some issues but overall I like this.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pitrou pitrou force-pushed the 14070-Remove-support-for-Visual branch from 366356b to 8e8bd9b Compare September 29, 2021 10:27
@pitrou
Copy link
Member

pitrou commented Sep 29, 2021

Rebased, will merge if CI green.

@pitrou pitrou closed this in d7467f4 Sep 29, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support.

See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3E

Closes apache#11211 from bkietz/14070-Remove-support-for-Visual

Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@bkietz bkietz deleted the 14070-Remove-support-for-Visual branch November 30, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants