-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-14070: [C++][CI] Remove support for VS2015 #11211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this :-)
appveyor.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this one but switch to a newer VS? It also differs by not using conda packages for dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created https://issues.apache.org/jira/browse/ARROW-14075 to add vs2019 and non-conda jobs
ci/appveyor-cpp-setup.bat
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this causes an exit-with-error-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need exit /B 1 for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice.
|
@github-actions crossbow submit win |
|
Revision: 6c96be131565277598667e6c8082b4878e5fa6bc Submitted crossbow builds: ursacomputing/crossbow @ actions-853 |
|
The verification tasks require additional prams and the vcpkg task is failing regardless of the PR (based on the nightly report). |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some issues but overall I like this.
kszucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
366356b to
8e8bd9b
Compare
|
Rebased, will merge if CI green. |
VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support. See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3E Closes apache#11211 from bkietz/14070-Remove-support-for-Visual Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support.
See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3E