-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-13637: [Python] Fix docstrings #11245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1e9d6ed
numpydoc fix for _json module
amol- f5584ba
numpy doc _csv module
amol- 323a823
Document types
amol- a92e6aa
Fix compute functions docstring
amol- 758df9d
Parquet docstrings
amol- 62c46cd
Address _fs docstrings
amol- cefdcf8
Fix pyarrow.ipc docstrings
amol- c5b034d
Fix feather and IPC
amol- d0d90ac
Document tensor and matrixes
amol- 95bf519
More docstrings
amol- ffb8736
Only compute functions pending
amol- f5ed74b
Remaining modules
amol- b6f36ae
Apply suggestions from code review
amol- 472339a
More docstrings for dataset and fs
amol- 0eea359
More work on docstrings
amol- e3fa416
Last docstrings
amol- 52a48d6
review comments
amol- 8461025
Lint
amol- e93d044
Apply suggestions from code review
amol- b282f37
Some review feedback
amol- de68f95
More feedback
amol- 74d5749
More feedback
amol- ee5f3ff
Further code review feedback
amol- a3a0274
lint
amol- 0aa9141
Address docstring for CSFTensor
amol- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the record, did you have to do these by hand or is there a mechanical fixer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did those by hand, I wanted to check what issues the docstrings had and thus had to look at them anyway. At that point fixing them was a minor deal.
If it doesn't already exist I guess that an automation to fix them wouldn't be too hard to build, but given that @kszucs has a PR to prevent broken/missing docstrings from happening again I hope this is the only time we have to do this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amol- yes, #7732 should be ready depending on which rules do we want to enable at first.