-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-14189: [Docs] Add version dropdown to the sphinx docs #11283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14189: [Docs] Add version dropdown to the sphinx docs #11283
Conversation
|
|
|
There is working happening for this in the upstream theme (pydata/pydata-sphinx-theme#436), but since that is not yet merged/released, I will "backport" it to our own docs. The basics already work here: Some notes:
|
|
Thanks @jorisvandenbossche for working on this! We need to update the release script to create and mount the right directory to the docker container which builds the documentation: mkdir -p ${ARROW_SITE_DIR}/docs/${version}
# ...
-v "${ARROW_SITE_DIR}/docs/${version}:/build/docs"We either need to use full version numbers in the selector or trim the version number in the release script to major and minor parts. Other than that can we merge this PR? |
ff72d4a to
ea69903
Compare
ea69903 to
c3dc3fc
Compare
kszucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joris!
|
Benchmark runs are scheduled for baseline = 311a953 and contender = 9c57eb3. 9c57eb3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Closes #11283 from jorisvandenbossche/ARROW-14189-version-dropdown Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Closes #11283 from jorisvandenbossche/ARROW-14189-version-dropdown Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>

No description provided.