Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@jorisvandenbossche
Copy link
Member Author

There is working happening for this in the upstream theme (pydata/pydata-sphinx-theme#436), but since that is not yet merged/released, I will "backport" it to our own docs.

The basics already work here:

Peek 2021-10-01 11-46

Some notes:

  • This is the basic, default styling of a dropdown from bootstrap (using the bootstrap primary color). We might want to style it a bit differently to have it fit better with our color scheme
  • Exact placement of the dropdown on the page can be improved
  • You can go back to earlier versions (and it preserves the page you are on), but those earlier versions don't have this dropdown (unless we would rebuild the older docs with this patch).

@kszucs
Copy link
Member

kszucs commented Oct 13, 2021

Thanks @jorisvandenbossche for working on this!

We need to update the release script to create and mount the right directory to the docker container which builds the documentation:

mkdir -p ${ARROW_SITE_DIR}/docs/${version}
# ...
-v "${ARROW_SITE_DIR}/docs/${version}:/build/docs"

We either need to use full version numbers in the selector or trim the version number in the release script to major and minor parts.

Other than that can we merge this PR?

@jorisvandenbossche jorisvandenbossche force-pushed the ARROW-14189-version-dropdown branch from ff72d4a to ea69903 Compare October 26, 2021 15:36
@jorisvandenbossche jorisvandenbossche force-pushed the ARROW-14189-version-dropdown branch from ea69903 to c3dc3fc Compare October 27, 2021 09:31
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joris!

@kszucs kszucs closed this in 9c57eb3 Oct 27, 2021
@ursabot
Copy link

ursabot commented Oct 27, 2021

Benchmark runs are scheduled for baseline = 311a953 and contender = 9c57eb3. 9c57eb3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.07% ⬆️0.58%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

kszucs pushed a commit that referenced this pull request Nov 3, 2021
Closes #11283 from jorisvandenbossche/ARROW-14189-version-dropdown

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
kszucs pushed a commit that referenced this pull request Nov 4, 2021
Closes #11283 from jorisvandenbossche/ARROW-14189-version-dropdown

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
@jorisvandenbossche jorisvandenbossche deleted the ARROW-14189-version-dropdown branch February 27, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants