ARROW-13975: [C++] Implement decimal round #11323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
arrow-13975
branch
2 times, most recently
from
23ea023 to
867aeeb
Compare
cyb70289
approved these changes
Oct 7, 2021
Contributor
cyb70289
left a comment
cyb70289
left a comment
There was a problem hiding this comment.
LGTM.
Nit: I find there are several typos in compute kernel document, round_mode table. Can we fix the typos altogether in this PR?
https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst
Search HALF_DOWN to locate the table.
Member
Author
|
I've updated the docs. Sorry, I'm not sure what the typos are - I fixed one example value but don't see anything else. |
Contributor
|
Sorry I didn't make it clear. I've updated the doc. Will merge when CI done. |
Contributor
|
Macos CI failures are not related. They also happen in other PRs. |
Member
Author
|
My bad, thanks for fixing those! |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Split out of ARROW-13130. Has some overlapping changes. Closes apache#11323 from lidavidm/arrow-13975 Lead-authored-by: David Li <li.davidm96@gmail.com> Co-authored-by: Yibo Cai <yibo.cai@arm.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of ARROW-13130. Has some overlapping changes.