Skip to content

ARROW-14382: [C++][Compute] Remove duplicated ThreadIndexer definition #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bkietz wants to merge 1 commit into from
Closed

ARROW-14382: [C++][Compute] Remove duplicated ThreadIndexer definition #11463

bkietz wants to merge 1 commit into from

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented Oct 19, 2021 •
edited
Loading

#11350 moved ThreadIndexer from aggregate_node.cc to compute/exec/util.h to allow usage from the join node and incremented its capacity, but did not remove the original implementation.

@bkietz
Copy link
Member Author

bkietz commented Oct 19, 2021

@github-actions crossbow submit test-ubuntu-18.04-cpp-static

@github-actions
Copy link

github-actions bot commented Oct 19, 2021

Revision: 396ce525cb97a6d4171b4e982233ecbe93df5b0a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1007

Task Status
test-ubuntu-18.04-cpp-static Github Actions

@bkietz bkietz changed the title [WIP] Remove duplicated ThreadIndexer definition ARROW-14382: [C++][Compute][WIP] Remove duplicated ThreadIndexer definition Oct 19, 2021
@github-actions
Copy link

github-actions bot commented Oct 19, 2021

https://issues.apache.org/jira/browse/ARROW-14382

@apache apache deleted a comment from github-actions bot Oct 19, 2021
@apache apache deleted a comment from github-actions bot Oct 19, 2021
@kszucs
Copy link
Member

kszucs commented Oct 19, 2021

@bkietz the static build is green now. Could you remove this from draft and trigger the builds?

@bkietz bkietz marked this pull request as ready for review October 19, 2021 14:25
@bkietz bkietz changed the title ARROW-14382: [C++][Compute][WIP] Remove duplicated ThreadIndexer definition ARROW-14382: [C++][Compute] Remove duplicated ThreadIndexer definition Oct 19, 2021
@bkietz bkietz requested a review from lidavidm October 19, 2021 14:26
@bkietz bkietz force-pushed the remove-duplicated-ThreadIndexer branch from 396ce52 to c8bed50 Compare October 19, 2021 14:31
@lidavidm lidavidm closed this in 54d2bd8 Oct 19, 2021
@ursabot
Copy link

ursabot commented Oct 19, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 11a45be and contender = 54d2bd8. 54d2bd8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.8% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@bkietz bkietz deleted the remove-duplicated-ThreadIndexer branch November 30, 2021 15:05
@asfimport asfimport mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz @kszucs @ursabot @lidavidm