Skip to content

ARROW-14437: [Python] Make CSV cancellation test more robust #11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-14437: [Python] Make CSV cancellation test more robust #11598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions python/pyarrow/tests/test_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,8 +1321,17 @@ def test_cancellation(self):
raise_signal = util.get_raise_signal()

# Make the interruptible workload large enough to not finish
# before the interrupt comes, even in release mode on fast machines
large_csv = b"a,b,c\n" + b"1,2,3\n" * 200_000_000
# before the interrupt comes, even in release mode on fast machines.
last_duration = 0.0
workload_size = 100_000

while last_duration < 1.0:
print("workload size:", workload_size)
large_csv = b"a,b,c\n" + b"1,2,3\n" * workload_size
t1 = time.time()
self.read_bytes(large_csv)
last_duration = time.time() - t1
workload_size = workload_size * 3

def signal_from_thread():
time.sleep(0.2)
Expand All @@ -1340,8 +1349,9 @@ def signal_from_thread():
except KeyboardInterrupt:
# In case KeyboardInterrupt didn't interrupt `self.read_bytes`
# above, at least prevent it from stopping the test suite
self.fail("KeyboardInterrupt didn't interrupt CSV reading")
pytest.fail("KeyboardInterrupt didn't interrupt CSV reading")
dt = time.time() - t1
# Interruption should have arrived timely
assert dt <= 1.0
e = exc_info.value.__context__
assert isinstance(e, pa.ArrowCancelled)
Expand Down