Skip to content

ARROW-254: remove Bit type as it is redundant with Boolean #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienledem wants to merge 1 commit into from
Closed

ARROW-254: remove Bit type as it is redundant with Boolean #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cpp/src/arrow/ipc/metadata-internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ static Status TypeFromFlatbuffer(flatbuf::Type type, const void* type_data,
return Status::Invalid("Type metadata cannot be none");
case flatbuf::Type_Int:
return IntFromFlatbuffer(static_cast<const flatbuf::Int*>(type_data), out);
case flatbuf::Type_Bit:
return Status::NotImplemented("Type is not implemented");
case flatbuf::Type_FloatingPoint:
return FloatFromFlatuffer(
static_cast<const flatbuf::FloatingPoint*>(type_data), out);
Expand Down
4 changes: 0 additions & 4 deletions format/Message.fbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ table Union {
mode: UnionMode;
}

table Bit {
}

table Int {
bitWidth: int; // 1 to 64
is_signed: bool;
Expand Down Expand Up @@ -62,7 +59,6 @@ table JSONScalar {

union Type {
Int,
Bit,
FloatingPoint,
Binary,
Utf8,
Expand Down