Skip to content

ARROW-14441: [R] Add our philosophy to the dev vignette #11705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thisisnic wants to merge 2 commits into from
Closed

ARROW-14441: [R] Add our philosophy to the dev vignette #11705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c96be7
Rebase from master
thisisnic Nov 19, 2021
1eec3a0
Update devdocs job to point ot the correct dir
thisisnic Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dev/tasks/r/github.devdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ jobs:
DEVDOCS_UBUNTU: {{ "${{contains(matrix.os, 'ubuntu')}}" }}
DEVDOCS_WINDOWS: {{ "${{contains(matrix.os, 'windows')}}" }}
run: |
# This isn't actually rendering the docs, but will save arrow/r/vignettes/script.sh
# This isn't actually rendering the docs, but will save arrow/r/vignettes/developers/script.sh
# which can be sourced to install arrow.
rmarkdown::render("arrow/r/vignettes/developing.Rmd")
rmarkdown::render("arrow/r/vignettes/developers/setup.Rmd")
shell: Rscript {0}
- name: Install from the devdocs
env:
Expand All @@ -68,9 +68,9 @@ jobs:
# from Windows paths (C:\R\bin) to Unix paths (/c/r/bin)
echo export PATH=\"$(cygpath --path "$PATH")\" >> ~/.bash_profile
# This starts a special mingw64 Git Bash shell
$RTOOLS40_HOME/msys2_shell.cmd -here -mingw64 -no-start -defterm -full-path arrow/r/vignettes/script.sh
else
bash arrow/r/vignettes/script.sh
$RTOOLS40_HOME/msys2_shell.cmd -here -mingw64 -no-start -defterm -full-path arrow/r/vignettes/developers/script.sh
else
bash arrow/r/vignettes/developers/script.sh
fi
shell: bash
- name: Ensure that the Arrow package is loadable and we have the correct one
Expand All @@ -88,5 +88,5 @@ jobs:
uses: actions/upload-artifact@v2
with:
name: {{ "devdocs-script_os-${{ matrix.os }}_sysinstall-${{ matrix.system-install }}" }}
path: arrow/r/vignettes/script.sh
path: arrow/r/vignettes/developers/script.sh
if: always()
4 changes: 4 additions & 0 deletions r/_pkgdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ navbar:
href: articles/developing.html
- text: Developers
menu:
- text: Developer Environment Setup
href: articles/developers/setup.html
- text: Common Workflow Tasks
href: articles/developers/workflow.html
- text: Debugging
href: articles/developers/debugging.html
reference:
Expand Down
Loading