ARROW-13886 [R] Expand documentation for decimal() #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dragosmg wants to merge 11 commits into apache:master from dragosmg:ARROW-13886_decimal_docs

Contributor

dragosmg commented Nov 22, 2021 •

edited

Loading

First attempt at this. Will be followed by:

opening Jira tickets to:
- deprecate decimal()
- implement decimal128() and decimal256()
expand unit tests both for data types and Arrays

Tickets generated:

implement decimal128() - https://issues.apache.org/jira/browse/ARROW-14843
implement decimal256() - https://issues.apache.org/jira/browse/ARROW-14844
improve messaging around Decimal128Type & Decimal256Type in the C++ code - https://issues.apache.org/jira/browse/ARROW-14842


          added 2 checks for precision and improved @param entries for `precisi…

eca6b1a

…on` and `scale` + docs + updated unit tests

github-actions bot commented Nov 22, 2021

https://issues.apache.org/jira/browse/ARROW-13886

github-actions bot added the Component: R label


          typo

3b9c5c5

thisisnic reviewed

View reviewed changes

r/R/type.R Outdated Show resolved Hide resolved

thisisnic reviewed

View reviewed changes

r/R/type.R Outdated Show resolved Hide resolved

thisisnic reviewed

View reviewed changes

r/R/type.R Outdated Show resolved Hide resolved

thisisnic reviewed

View reviewed changes

r/R/type.R Outdated Show resolved Hide resolved


          update docs and args def

b71edd8

thisisnic reviewed

View reviewed changes

r/tests/testthat/test-data-type.R Outdated Show resolved Hide resolved

thisisnic reviewed

View reviewed changes

Member

thisisnic left a comment

A few pedantic changes but otherwise looks good. Won't approve yet as I think you're still making changes.


          typo

ef3b446

jonkeane requested changes

View reviewed changes

Member

jonkeane left a comment

Thanks for this, looking good so far, a few questions / comments

r/R/type.R Show resolved Hide resolved

r/R/type.R Outdated Show resolved Hide resolved

r/tests/testthat/test-data-type.R Outdated Show resolved Hide resolved


          added more description for decimal()

65786cc

dragosmg requested a review from jonkeane

November 23, 2021 14:04

jonkeane approved these changes

View reviewed changes

Member

jonkeane left a comment

Looking good — a few small comments

r/R/type.R Show resolved Hide resolved

r/tests/testthat/test-data-type.R Outdated Show resolved Hide resolved


          Merge branch 'master' of https://github.com/dragosmg/arrow into ARROW…

fe4387c

…-13886_decimal_docs

Contributor Author

dragosmg commented Nov 24, 2021

Raised a Jira to improve the error messaging and reverted to use the error messages as surfaced from the C++ code


          revert to C++ error messaging

d81f406

pitrou reviewed

View reviewed changes

r/R/type.R Show resolved Hide resolved

dragosmg added 2 commits

November 24, 2021 15:47


          improve docs for decimal()

930157b


          add a comment near the tests likely to be affected by ARROW-14842

47513b4

dragosmg requested a review from jonkeane

November 24, 2021 16:00

dragosmg added 2 commits

November 25, 2021 11:03


          removing comment as ARROW-14842 is being addressed

2fc3564


          Merge branch 'master' of https://github.com/dragosmg/arrow into ARROW…

b064d86

…-13886_decimal_docs

thisisnic closed this in

d722f50

ursabot commented Nov 27, 2021 •

edited

Loading

Benchmark runs are scheduled for baseline = 35b3567 and contender = d722f50. d722f50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.44% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

dragosmg deleted the ARROW-13886_decimal_docs branch

December 6, 2021 16:14

asfimport mentioned this pull request

[R] Expand documentation for decimal() #29502

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels