Skip to content

ARROW-14659: [R] Remove warning about factor conversion to string in if_else() #11794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephhazlitt wants to merge 5 commits into from
Closed

ARROW-14659: [R] Remove warning about factor conversion to string in if_else() #11794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32482a4
rm if_else type warning
stephhazlitt Nov 29, 2021
f91d907
r warning from if_else test
stephhazlitt Nov 29, 2021
a13b4a5
reset factor levels in test
stephhazlitt Nov 29, 2021
a4d9378
Update r/tests/testthat/test-dplyr-funcs-conditional.R
stephhazlitt Nov 29, 2021
ae404c9
Update r/tests/testthat/test-dplyr-funcs-conditional.R
stephhazlitt Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions r/R/dplyr-functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,17 +908,6 @@ nse_funcs$if_else <- function(condition, true, false, missing = NULL) {
))
}

# if_else doesn't yet support factors/dictionaries
# TODO: remove this after ARROW-13358 is merged
warn_types <- nse_funcs$is.factor(true) | nse_funcs$is.factor(false)
if (warn_types) {
warning(
"Dictionaries (in R: factors) are currently converted to strings (characters) ",
"in if_else and ifelse",
call. = FALSE
)
}

build_expr("if_else", condition, true, false)
}

Expand Down
14 changes: 8 additions & 6 deletions r/tests/testthat/test-dplyr-funcs-conditional.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,18 +116,20 @@ test_that("if_else and ifelse", {
tbl
)

# TODO: remove the mutate + warning after ARROW-13358 is merged and Arrow
# supports factors in if(_)else
compare_dplyr_binding(
.input %>%
mutate(
y = if_else(int > 5, fct, factor("a"))
) %>%
collect() %>%
# This is a no-op on the Arrow side, but necessary to make the results equal
mutate(y = as.character(y)),
tbl,
warning = "Dictionaries .* are currently converted to strings .* in if_else and ifelse"
# Arrow if_else() kernel does not preserve unused factor levels,
# so reset the levels of all the factor columns to make the test pass
# (ARROW-14649)
transmute(across(
where(is.factor),
~ factor(.x, levels = c("a", "b", "c", "d", "g", "h", "i", "j"))
)),
tbl
)

# detecting NA and NaN works just fine
Expand Down