Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Dec 1, 2021

The function is too dangerous for GCS. Leave it unimplemented, with a
message that explains why, and add a test.

The function is too dangerous for GCS. Leave it unimplemented, with a
message that explains why, and add a test.
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@coryan coryan marked this pull request as ready for review December 1, 2021 15:17
@coryan
Copy link
Contributor Author

coryan commented Dec 1, 2021

The C++ / AMD64 Conda C++ failure seems unrelated.

@pitrou
Copy link
Member

pitrou commented Dec 2, 2021

The C++ / AMD64 Conda C++ failure seems unrelated.

Indeed!

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou closed this in 55ebeb3 Dec 2, 2021
@ursabot
Copy link

ursabot commented Dec 2, 2021

Benchmark runs are scheduled for baseline = b8431fb and contender = 55ebeb3. 55ebeb3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.4% ⬆️0.18%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan coryan deleted the ARROW-14914-gcsfs-delete-root-dir-contents branch December 2, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants