Skip to content

ARROW-14979: [C++] Fix process leaks in GCS integration tests #11852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coryan wants to merge 1 commit into from
Closed

ARROW-14979: [C++] Fix process leaks in GCS integration tests #11852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/src/arrow/filesystem/gcsfs_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ culpa qui officia deserunt mollit anim id est laborum.
class GcsIntegrationTest : public ::testing::Test {
public:
~GcsIntegrationTest() override {
// Brutal shutdown, kill the full process group because the GCS testbench may launch
// additional children.
group_.terminate();
if (server_process_.valid()) {
// Brutal shutdown
server_process_.terminate();
server_process_.wait();
}
}
Expand All @@ -81,7 +82,7 @@ class GcsIntegrationTest : public ::testing::Test {
ASSERT_THAT(exe_path, Not(IsEmpty()));

server_process_ = bp::child(boost::this_process::environment(), exe_path, "-m",
"testbench", "--port", port_);
"testbench", "--port", port_, group_);

// Create a bucket and a small file in the testbench. This makes it easier to
// bootstrap GcsFileSystem and its tests.
Expand Down Expand Up @@ -141,6 +142,7 @@ class GcsIntegrationTest : public ::testing::Test {
std::mt19937_64 generator_;
std::string port_;
bp::child server_process_;
bp::group group_;
};

TEST(GcsFileSystem, OptionsCompare) {
Expand Down