Skip to content

ARROW-14479: [C++] Hash Join Microbenchmarks #11876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
save-buffer wants to merge 16 commits into from
Closed

ARROW-14479: [C++] Hash Join Microbenchmarks #11876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
24c40cd
Add benchmarking for hash join
save-buffer Nov 6, 2021
e1706c1
Parameterize the fixture, including making it multithreaded with OMP
save-buffer Nov 16, 2021
cd3c6ca
Add some more benchmarks
save-buffer Nov 25, 2021
f3c1fdc
Add cardinality and selectivity
save-buffer Dec 1, 2021
59e8cd9
Add python script
save-buffer Dec 7, 2021
d3ce1e3
cmake-format
save-buffer Dec 7, 2021
ca30b92
clang-format
save-buffer Dec 7, 2021
49f7d53
Add license header
save-buffer Dec 7, 2021
4b99774
Linter comments
save-buffer Dec 7, 2021
d81a94e
Make openmp work on msvc
save-buffer Dec 9, 2021
08b5234
Respond to comments
save-buffer Dec 13, 2021
5e1e329
Switch to rows/sec, make script a bit more intelligent with categoric…
save-buffer Dec 14, 2021
ce9cec0
Respond to some more comments
save-buffer Dec 15, 2021
4f3bf2d
clang-format
save-buffer Dec 15, 2021
f182ddf
Add ARROW_BUILD_DETAILED_BENCHMARKS flag
save-buffer Jan 5, 2022
ddab7f5
Respond to Weston comments, switch to log scale when prudent
save-buffer Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"cacheVariables": {
"ARROW_BUILD_BENCHMARKS": "ON",
"ARROW_BUILD_BENCHMARKS_REFERENCE": "ON",
"ARROW_BUILD_OPENMP_BENCHMARKS": "ON",
"ARROW_BUILD_DETAILED_BENCHMARKS": "OFF",
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
Expand Down
4 changes: 4 additions & 0 deletions cpp/cmake_modules/BuildUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,10 @@ function(ADD_BENCHMARK REL_BENCHMARK_NAME)
set(ARG_LABELS benchmark)
endif()

if(ARROW_BUILD_DETAILED_BENCHMARKS)
target_compile_definitions(${BENCHMARK_NAME} PRIVATE ARROW_BUILD_DETAILED_BENCHMARKS)
endif()

add_test(${BENCHMARK_NAME}
${BUILD_SUPPORT_DIR}/run-test.sh
${CMAKE_BINARY_DIR}
Expand Down
6 changes: 6 additions & 0 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
define_option(ARROW_BUILD_BENCHMARKS_REFERENCE
"Build the Arrow micro reference benchmarks" OFF)

define_option(ARROW_BUILD_OPENMP_BENCHMARKS
"Build the Arrow benchmarks that rely on OpenMP" OFF)

define_option(ARROW_BUILD_DETAILED_BENCHMARKS
"Build benchmarks that do a longer exploration of performance" OFF)

if(ARROW_BUILD_SHARED)
set(ARROW_TEST_LINKAGE_DEFAULT "shared")
else()
Expand Down
13 changes: 13 additions & 0 deletions cpp/src/arrow/compute/exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@ add_arrow_compute_test(util_test PREFIX "arrow-compute")

add_arrow_benchmark(expression_benchmark PREFIX "arrow-compute")

if(ARROW_BUILD_OPENMP_BENCHMARKS)
find_package(OpenMP REQUIRED)
add_arrow_benchmark(hash_join_benchmark
PREFIX
"arrow-compute"
EXTRA_LINK_LIBS
OpenMP::OpenMP_CXX)
if(MSVC)
target_compile_options(arrow-compute-hash-join-benchmark
PRIVATE "-openmp:experimental -openmp:llvm")
endif()
endif()

add_arrow_compute_test(ir_test
PREFIX
"arrow-compute"
Expand Down
Loading